Allow disabling remote tabs in the Urlbar without disabling them elsewhere
Categories
(Firefox :: Address Bar, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox97 | --- | verified |
People
(Reporter: dqeswn, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Results matching the search term are now interfered by sync.
What previously appeared as normal results now are "overwritten" by sync items.
So instead of seeing normal items I get items with blank favicons as well as the URLs being removed and only show "Firefox here: <Device name>".
So they're double reduced. I can't quickly find a site's item by favicon, nor can I see the url. The title is there, but of course it might be nondescript. And there's usually zero indication of the website.
I upgraded from FF88, so I don't know when this happened, but it's quite a hefty issue.
On 88 I sometimes saw device tabs, but they seemed to be additional items. And not this local item butchering nonsense. Also, even for those I don't recall the favicons becoming blank.
I see no purpose use for this at all. I want to find an item quickly, I don't care that it was already opened on a device that I'm not even using.
I do use synced tab through the sidebar when I want to continue browsing what I started on mobile.
|
Assignee | |
Comment 1•2 years ago
|
||
Remote tabs were re-worked in bug 1677126, which landed in Fx 91. Part of that change was increasing the number of remote tabs shown in some circumstances. Previously, we only showed remote tabs opened in the last 72 hours. Now, we show up to 3 recent remote tabs, then other results, then older remote tabs at the end if there's space left over. We discard a local result if there's an identical synced tab result so as to not show duplicate results.
The issue of the favicons not appearing is indeed annoying. I've noticed this before too. I thought we had a bug on file about it, but it appears we don't. Could you please take a screenshot of the results with no icons and file a bug specifically about that issue?
As for this issue of not wanting to see remote tab results, I'll write a quick patch to add a pref to disable their display in the address bar. I won't add it to about:preferences just yet, however. The Search preferences are a mess, and adding another checkbox would make them even more confusing. Cleaning up preferences is one of our priorities for 2022, so we can add it then.
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
Okay, this patch lands in Firefox 97. In Fx 97, you can disable remote tab results without disabling remote tabs in general by toggling the pref browser.urlbar.suggest.remotetab.
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ee724d61fa4e Allow disabling remote tabs in the Urlbar without disabling tab sync. r=adw
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Sorry for not being around, but apparently I get no bugmail anymore. No idea why. Was this feature disabled on bugzilla?
(In reply to Harry Twyford from comment #1)
Remote tabs were re-worked in bug 1677126, which landed in Fx 91. Part of that change was increasing the number of remote tabs shown in some circumstances. Previously, we only showed remote tabs opened in the last 72 hours. Now, we show up to 3 recent remote tabs, then other results, then older remote tabs at the end if there's space left over. We discard a local result if there's an identical synced tab result so as to not show duplicate results.
The issue of the favicons not appearing is indeed annoying. I've noticed this before too. I thought we had a bug on file about it, but it appears we don't. Could you please take a screenshot of the results with no icons and file a bug specifically about that issue?
I would also say that the url missing is equally problematic. Can't the indication of the tab is opened on a device simply push the url to the right, if it's a must. (Not sure how long the shown device name is allowed to be)
But I don't know why it would be. If there is a local result, why show that it's open in a specific device as well, to remind someone that he might want to close it? Is that worth it?
Isn't it enough to just indicate it visually? Similar to the bookmark star which is in the bottom right corner of the favicon, there might be a little sync icon on the top right corner.
As an extra item it's as long as it's a good "frecency" match, it's good idea to show sync results.
Is your question abut filing a bug for not showing the favicon still relevant? Or was one filed in the meanwhile?
As for this issue of not wanting to see remote tab results, I'll write a quick patch to add a pref to disable their display in the address bar. I won't add it to about:preferences just yet, however. The Search preferences are a mess, and adding another checkbox would make them even more confusing. Cleaning up preferences is one of our priorities for 2022, so we can add it then.
(In reply to Harry Twyford from comment #3)
Okay, this patch lands in Firefox 97. In Fx 97, you can disable remote tab results without disabling remote tabs in general by toggling the prefbrowser.urlbar.suggest.remotetab.
Great! I will upgrade soon.
verified on windows10, MacOS 10.15 and Ubunbu 21 on beta97 and Nightly 98 that browser.urlbar.suggest.remotetab disables the remote tabs in urlbar
|
||
Comment 8•2 years ago
|
||
(In reply to avada from comment #6)
Is your question abut filing a bug for not showing the favicon still relevant? Or was one filed in the meanwhile?
Yes, it's still relevant -- I haven't seen a bug filed for it recently and a quick search didn't find one. Would you be able to get a screenshot of it happening and file a bug, as Harry suggested?
(In reply to Drew Willcoxon :adw from comment #8)
(In reply to avada from comment #6)
Is your question abut filing a bug for not showing the favicon still relevant? Or was one filed in the meanwhile?
Yes, it's still relevant -- I haven't seen a bug filed for it recently and a quick search didn't find one. Would you be able to get a screenshot of it happening and file a bug, as Harry suggested?
I did now.
Description
•