1746804 - Stop clearing browser.ctrlTab.recentlyUsedOrder when migrating the pref (was: browser.ctrlTab.sortByRecentlyUsed set to false when upgrading from esr78 to esr91)

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Mike Hommey [:glandium]]

With bug 1692303 and bug 1701542, browser.ctrlTab.recentlyUsedOrder was renamed and flipped to false,, except if ctrl-tab was detected as having been used... through a pref that was added in bug 1687703, which landed in 86. So people who were using ctrl-tab in esr78, and then upgraded to the next esr (i.e. esr91), see the pref reset because they had no occasion for the browser.engagement.ctrlTab.has-used pref to be set.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Dão Gottwald [:dao]]

bigiri, can you look into this? It looks like the migration code (needlessly?) clears the old pref, so at this point I guess there's no way to remedy this with an update for users already on ESR91?

Comment 3

[Bernard Igiri]

Unfortunately ESR78 is no longer supported. We missed this detail when the patch was merged and there's not much we can do about it. I spoke with @mconley and he suggests that I mark this as "won't fix." If you have more questions Mike says that he will take those, so please direct further questions to him. Thank you.

Comment 4

[Dão Gottwald [:dao]]

I'm reopening this in order to remove the pref clearing, if only to prevent this pattern from being copied by future migration code.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1746804 - When migrating browser.ctrlTab.recentlyUsedOrder, stop clearing it so there's a backup in case of wrongful migration. r=mconley

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d09faf561bb
When migrating browser.ctrlTab.recentlyUsedOrder, stop clearing it so there's a backup in case of wrongful migration. r=mconley

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0d09faf561bb