browser_popup_condition.js is slow on Linux hw webrender
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox97 | --- | fixed |
People
(Reporter: Gijs, Assigned: arai)
References
Details
Attachments
(2 files)
The patch in bug 1544167 apparently tipped this test over the edge just on Linux hw webrender - but bug 1739753 suggests that this isn't the first time we've had issues with this test. It's worth noting that although it failed on a TV job, it actually failed in the very first run of the test in question... suggesting that inasmuch as it passes on infra, it does so as a result of side-effects of the tests that precede it in the same directory...
I'd suggest creating a head.js function that produces the relevant features/popup object combinations, and then writing 3 separate tests using that utility function for the different set: browser.link.open_newwindow preference values, effectively splitting the test into 3.
This test opens some 100 windows and 200 new tabs, so it's no real surprise it takes a while. It'd also be useful to think how much of that test coverage is valuable and if there's some way we can reduce the amount of work the test does without reducing coverage. :arai, do you have other/better ideas than my suggestion to split up the test?
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D134371
|
|
Assignee | |
Updated•2 years ago
|
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/359dffddf78c Part 1: Reduce redundant testcase from browser_popup_condition.js. r=Gijs https://hg.mozilla.org/integration/autoland/rev/f56680584025 Part 2: Split browser_popup_condition.js for each pref. r=Gijs
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/359dffddf78c
https://hg.mozilla.org/mozilla-central/rev/f56680584025
Description
•