Closed Bug 1746867 Opened 4 years ago Closed 4 years ago

Outgoing actions are canceled by OTR in non-OTR direct chats

Categories

(Chat Core :: Security: OTR, defect)

Desktop
All
defect

Tracking

(thunderbird_esr91 wontfix, thunderbird96 affected, thunderbird97 fixed)

RESOLVED FIXED
97 Branch
Tracking Status
thunderbird_esr91 --- wontfix
thunderbird96 --- affected
thunderbird97 --- fixed

People

(Reporter: freaktechnik, Assigned: freaktechnik)

Details

Attachments

(1 external file)

STR:

  • Send a /me in a direct chat

Expected result:
See the action in your local chat window

Actual result:
While the message is sent by the protocol implementation, it gets canceled. As far as I can tell by the OTR code, and thus is never displayed.

Filing this in Chat Core:General since I'm not entirely certain it is solely OTR's fault.

I've primarily observed this with Matrix. It is likely this is happening because Matrix currently doesn't send its emotes/actions through the OutgoingMessage loop, and thus OTR never sees the message and cancels it. I think OTR shouldn't be canceling all outgoing messages it doesn't know about in pluckMsg. They might also be from other clients, for example.

Assignee: nobody → martin
Status: NEW → ASSIGNED
Component: General → Security: OTR
Target Milestone: --- → 97 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/88b9c3af8fec
Only cancel otr encrypted messages that aren't found in the buffer. r=clokep

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: