1746874 - Airflow task crash_symbolication.modules_with_missing_symbols failing on 2021-12-19

Status: RESOLVED FIXED

(Data Platform and Tools :: General, defect)

Description

[Jeff Klukas [:klukas] (UTC-4)]

Airflow task crash_symbolication.modules_with_missing_symbols failing on 2021-12-19

From logs:

len(top_missing): 322
Traceback (most recent call last):
  File "/tmp/modules-with-missing-symbols_a340e497/modules_with_missing_symbols.py", line 129, in <module>
    top_missing = [m for m in top_missing if not is_old_firefox_module(m)]
  File "/tmp/modules-with-missing-symbols_a340e497/modules_with_missing_symbols.py", line 129, in <listcomp>
    top_missing = [m for m in top_missing if not is_old_firefox_module(m)]
  File "/tmp/modules-with-missing-symbols_a340e497/modules_with_missing_symbols.py", line 126, in is_old_firefox_module
    return any(version.startswith(v + ".") for v in old_firefox_versions)
  File "/tmp/modules-with-missing-symbols_a340e497/modules_with_missing_symbols.py", line 126, in <genexpr>
    return any(version.startswith(v + ".") for v in old_firefox_versions)
AttributeError: 'NoneType' object has no attribute 'startswith'

I'm going to try clearing to see if this is transient.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Feel free to tag me in if retrying doesn't help.

Comment 2

[Jeff Klukas [:klukas] (UTC-4)]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #1)

Feel free to tag me in if retrying doesn't help.

Indeed it appears that retries are failing.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/python_mozetl/pull/362

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 362: bug 1746874: fix case where version is None

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I cleared the thing in the thing and now the DAG succeeded and the email got sent.

What happened is that this DAG runs once a week. Last week, we switched to a new stackwalker that has slightly different behavior in some cases. In this case, the new stackwalker sets modules.N.version to null whereas the old stackwalker set it to "" (the empty string). The script failed because it has no handling for non-strings in the is_old_firefox_module function. So I fixed it to handle nulls (None in Python) as well.

Marking as FIXED.