1746893 - Relax AudioDriftCorrection's thread limitation

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, enhancement, P1)

Description

[C.M.Chang[:chunmin]]

By the comment in AudioDriftCorrection: "The construction can happen in any thread", the AudioDriftCorrection class is ought to be created in any thread, but it's not true actually. The fact that ctor calls Preferences::GetInt makes it can only be called on main-thread, which
is the thread Preferences::GetInt should be.

To make AudioDriftCorrection work as what it's expected, the preference getter should be moved to the AudioDriftCorrection's caller rather than AudioDriftCorrection's ctor.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1746893 - Relax AudioDriftCorrection's thread limitation

By the comment in AudioDriftCorrection: "The construction can happen
in any thread", the AudioDriftCorrection class is ought to be created
in any thread, but it's not true actually. The fact that ctor calls
Preferences::GetInt makes it can only be called on main-thread, which
is the thread Preferences::GetInt should be.

To make AudioDriftCorrection work as what it's expected, the
preference getter should be moved to the AudioDriftCorrection's caller
rather than AudioDriftCorrection's ctor.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0714fcb047ac
Relax AudioDriftCorrection's thread limitation r=padenot,pehrsons

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0714fcb047ac