[QM_TRY] Failures in dom/quota/ActorsParent.cpp:GetTemporaryStorageLimit
Categories
(Core :: Storage: Quota Manager, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: jan.rio.krause, Assigned: jjalkanen)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(1 file)
|
Reporter | |
Comment 1•2 years ago
|
||
Taken from Attachment 9256168 [details].
| Clients | Sessions | Hits | Anchor | Stack |
|---|---|---|---|---|
| 1 | 1 | 7 | dom/quota/ActorsParent.cpp:GetTemporaryStorageLimit | dom/quota/ActorsParent.cpp#2668:NS_ERROR_FAILURE <- dom/quota/ActorsParent.cpp#6376:NS_ERROR_FAILURE <- dom/localstorage/ActorsParent.cpp#6776:NS_ERROR_FAILURE |
| 2 | 2 | 2 | dom/quota/ActorsParent.cpp:GetTemporaryStorageLimit | dom/quota/ActorsParent.cpp#2668:NS_ERROR_FAILURE <- dom/quota/ActorsParent.cpp#6376:NS_ERROR_FAILURE |
|
||
Comment 2•2 years ago
|
||
Assuming this happens on Windows, Jari, can you take a look?
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 4•2 years ago
|
||
(Assuming that this is not severe, but feel free to change if it is.)
|
|
||
Comment 5•2 years ago
|
||
The frequency suggests it is not too severe, yes. Still GetTemporaryStorageLimit should be kind of infallible and we may want to have a better error propagation in case the OS cannot determine the disk size (which is the main underlying operation here) to see if we can mitigate any valid error state we did not consider.
|
||
Comment 7•2 years ago
|
||
I wonder if the same error was already tracked before under QuotaManager::EnsureTemporaryStorageIsInitialized because the GetDiskSpaceAvailable/GetDiskSpace call lived there before we move it to GetTemporaryStorageLimit.
|
|
Reporter | |
Comment 8•2 years ago
|
||
Taken from Attachment 9259422 [details].
|
|
Reporter | |
Comment 9•2 years ago
|
||
Taken from Attachment 9263751 [details].
| Clients | Sessions | Hits | Anchor | Stack |
|---|---|---|---|---|
| 3 | 10 | 21 | dom/quota/ActorsParent.cpp:GetTemporaryStorageLimit | dom/quota/ActorsParent.cpp#2668:NS_ERROR_FAILURE <- dom/quota/ActorsParent.cpp#6376:NS_ERROR_FAILURE |
|
|
Assignee | |
Comment 10•2 years ago
|
||
|
|
Reporter | |
Comment 11•2 years ago
|
||
Taken from Attachment 9269668 [details].
| Clients | Sessions | Hits | Anchor | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/quota/ActorsParent.cpp:GetTemporaryStorageLimit | dom/quota/ActorsParent.cpp#2684:NS_ERROR_GENERATE_FAILURE(NS_ERROR_MODULE_WIN32, 0x1B1) <- dom/quota/ActorsParent.cpp#6404:NS_ERROR_GENERATE_FAILURE(NS_ERROR_MODULE_WIN32, 0x1B1) |
|
||
Comment 12•2 years ago
|
||
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47a5cc9cd2f6 Handle GetTemporaryStorageLimit failures with upper limit. r=dom-storage-reviewers,jesup
|
||
Comment 13•2 years ago
|
||
Backed out for causing build bustages on ActorsParent.cpp
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:2700:47: error: overflow in expression; result is 0 with type 'int' [-Werror,-Winteger-overflow]
|
|
||
Comment 14•2 years ago
|
||
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02f4220a827c Handle GetTemporaryStorageLimit failures with upper limit. r=dom-storage-reviewers,jesup
|
|
||
Comment 15•2 years ago
|
||
Backed out for causing mochitest failures on antitracking_head.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_blockingDOMCache.js | uncaught exception - NS_NOINTERFACE: Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface] at observe@chrome://mochitests/content/browser/toolkit/components/antitracking/test/browser/antitracking_head.js:670:20
|
|
||
Comment 16•2 years ago
|
||
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c68770cc4ff Handle GetTemporaryStorageLimit failures with upper limit. r=dom-storage-reviewers,jesup
|
||
Comment 17•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 18•2 years ago
|
||
The test caught an integer issue which was fixed before landing.
Description
•