1747022 - Always show the grab space on draw in tittle bar

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

We have now on three different places the code to create the drag space. Thanks to bug 1736437 we can now unify this.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1747022-unify-grab-space.patch

Move it to the shared tabmail.css.
After bug 1736437 the grab space doesn't work on Mac because of a wrong selector. With this patch it's fixed.

Comment 2

[Richard Marti (:Paenglab)]

What I forgot to write (and is also the reason for the bug title): When the window is maximized we hide the grab space but we should still show it to make it possible to grab the window also with a lot of tabs open.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9256305 [details] [diff] [review]
1747022-unify-grab-space.patch

Review of attachment 9256305 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0c5ec587cd58
Always show the grab space on draw in title bar. r=aleca

Comment 5

[Alessandro Castellani [:aleca]]

I found a couple of adjacent issues maybe we can address with a small follow up patch.

on macOS, the standlone window (eg. when reading a message in a new window), has an empty titlebar which it shouldn't be there.
This code can be removed I guess, I'm not sure how I missed it and why it's still there: https://searchfox.org/comm-central/rev/584d9749d278317b5eeb73477df1aec25ef921c7/mail/themes/osx/mail/messenger.css#66-68

on macOS, the toolbar handling calendar and task tab buttons is too attached to the edge of the window. It should have a margin inline end of 9px.

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: Bug 1747022 - [macOS] Fix titlebar in single window and add end space to tabbar toolbar.r=Paenglab

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c89f37eb47dd
[macOS] Fix titlebar in single window and add end space to tabbar toolbar.r=Paenglab