1747056 - MessageDisplayAction buttons ignore theme_icons

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1747056 - Make MessageDisplayAction buttons use the defined theme_icons. r=Paenglab

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ff6f7251f84d
Make MessageDisplayAction buttons use the defined theme_icons. r=Paenglab

Comment 3

[Magnus Melin [:mkmelin]]

This is apparently causing comm/mail/components/extensions/test/browser/browser_ext_browserAction.js to fail.
It's an intermittent but almost perma on CI. Can be reproduced locally with --verify, but not without. (Backing out the patch -> verify succeeds)

Comment 4

[Magnus Melin [:mkmelin]]

Backout: https://hg.mozilla.org/comm-central/rev/ae6bcef5c40bbccc902c1fadeeea90007c998dbd

Comment 5

[John Bieling (:TbSync)]

Apparently, enabling the default theme does not work reliably for Linux tests. I changed the tests to start with enabling the light and dark themes and then disable the selected theme, which enables the default theme. This gave me no more failures with --verify

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/994662a74ca3
Make MessageDisplayAction buttons use the defined theme_icons. r=Paenglab

Comment 7

[John Bieling (:TbSync)]

I am having a hard time to get the test working. On my local linux system, the default theme picks the "light" icon for the compose action button, but on our test infra it takes the "default" icon (like it does for windows on my machine as well).

I could of course just adjust the test to pass on our test infra, but I would like to make it in a way, that it always works.

a) do you have any idea what might cause this?
b) can I enforce a consistent behavior?
c) can I detect what the used icon should be by checking an attribute or alike?

Failing test:
comm/mail/components/extensions/test/browser/browser_ext_composeAction.js

Fail report:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&author=john.bieling%40gmx.de&selectedTaskRun=HlpTj-PQQEKX46z5he-xbw.0

Comment 8

[Richard Marti (:Paenglab)]

What Linux theme do you use (a dark?) and what theme uses the infra (probably a light)? This could be the difference. You should test locally with a similar theme like the test infra uses.

Comment 9

[John Bieling (:TbSync)]

Huh, so that is really something we cannot control? If the users OS theme is different, the test will fail?

Is it a good idea to add such a test?

Is it possible to somehow detect by looking at a DOM attribute (which also triggers the actual icon usage), what theme the user is using, or what icon should be used in the users environment?

Comment 10

[Richard Marti (:Paenglab)]

Instead of relying on the system theme would it be possible to use the dark and light built-in TB themes? Then there would be a defined environment for the tests and you could also check if the icon changes on theme change. I don't know not enough about the tests. Maybe you could check which icon variable is set on the button.

Comment 11

[John Bieling (:TbSync)]

I am using the built-in TB dark, light and default themes:
https://searchfox.org/comm-central/rev/9cc6232e1e348539487fb4853bb5e19f623a7b0b/mail/components/extensions/test/browser/browser_ext_composeAction.js#234-247

That is what puzzles me.

Comment 12

[John Bieling (:TbSync)]

When I change my Linux System Theme from Standard to Light, then it behaves like our test infra.

Comment 13

[John Bieling (:TbSync)]

Attachment: Bug 1747056 - Adjust composeAction test to the light Linux theme used by CI. r=darktrojan

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/596baaaf3374
Adjust composeAction test to the light Linux theme used by CI. r=darktrojan