1747086 - Replace /me special handling with a flag

Status: RESOLVED FIXED

(Chat Core :: General, task)

Description

[Patrick Cloke [:clokep]]

Attachment: WIP

We do a lot of special handling for messages that start with /me (like prepending it for protocols that have a different way of describing an action message). It is more ideal to just use a flag. This should clean-up some of the logic in the core and make some of the protocols less hacky.

I've attached a work in progress patch for this. The parent changeset is quite old so it has probably bitrotted unfortunately.

Comment 1

[Patrick Cloke [:clokep]]

Comment on attachment 9256380 [details] [diff] [review]
WIP

Review of attachment 9256380 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/xmpp/xmpp-base.jsm
@@ +999,5 @@
>        flags.error = true;
>      } else {
>        flags = { incoming: true, _alias: this.contactDisplayName };
> +      // XEP-0245: The /me Command.
> +      if (aMsg.startsWith("\me ")) {

This seems to use the wrong slash.

Comment 2

[Martin Giger [:freaktechnik]]

I think it would also make sense to have the /me commands go through sendMsg so we can unify the OutgoingMessage story. To do so I'd suggest adding a second param to sendMsg that is true if the message that is being sent is an action.

Comment 3

[Martin Giger [:freaktechnik]]

(In reply to Martin Giger [:freaktechnik] from comment #2)

I think it would also make sense to have the /me commands go through sendMsg so we can unify the OutgoingMessage story. To do so I'd suggest adding a second param to sendMsg that is true if the message that is being sent is an action.

I actually ended up doing that in the patch for bug 1747090.

Comment 4

[Patrick Cloke [:clokep]]

I have a patch for this which builds on bug 1760176.

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Bug 1747086 - Replace /me special handling with a flag. r=freaktechnik

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/db05c48a9ab2
Replace /me special handling with a flag. r=freaktechnik

Comment 7

[Patrick Cloke [:clokep]]

Bug 1735353 also fixed a couple of issues with this when loading messages from logs.