Closed
Bug 1747128
Opened 2 years ago
Closed 2 years ago
Missing locks in DoH code
Categories
(Core :: Networking: DNS, defect, P1)
Core
Networking: DNS
Tracking
()
RESOLVED
FIXED
97 Branch
People
(Reporter: jesup, Assigned: jesup)
References
(Blocks 1 open bug)
Details
(Keywords: csectype-race, sec-moderate, Whiteboard: [post-critsmash-triage][post-critsmash-triage][adv-main97+r])
Attachments
(1 file)
There are several spots where we appear to missing required locks in the DoH. This is based on Clang thread-safety static analysis, with the annotations to tell it that all members in ODoHService other than mTTLTimer require the lock, which appears to be the case.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
|
||
Updated•2 years ago
|
Severity: -- → S2
Priority: -- → P1
Whiteboard: [necko-triaged]
|
||
Comment 3•2 years ago
|
||
DoH cleanup r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/e80f97eec5388ee563a5351b3441cbf14b586aa9
https://hg.mozilla.org/mozilla-central/rev/e80f97eec538
Group: core-security → core-security-release
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox97:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
Flags: qe-verify-
Whiteboard: [necko-triaged] → [necko-triaged][post-critsmash-triage]
|
||
Updated•2 years ago
|
Whiteboard: [necko-triaged][post-critsmash-triage] → [post-critsmash-triage][post-critsmash-triage][adv-main97+r]
|
||
Updated•2 years ago
|
Group: core-security-release
You need to log in
before you can comment on or make changes to this bug.
Description
•