1747164 - TextLeafPoint::GetTextAttributesLocalAcc fails with date/time input leafs

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

I would like that to be true, but take the following example:
data:text/html,<input type="date">

The HTMLDateTimeAccessible is not a hypertext accessible subclass and it has children that are text leafs (like "/" in the US locale).

Comment 1

[Eitan Isaacson [:eeejay]]

I guess the right solution is to make HTMLDateTimeAccessible subclass HyperTextAccessibleWrap?

Comment 2

[James Teh [:Jamie]]

I think that's the correct solution, yes. That would explain bug 1744150.

Comment 3

[James Teh [:Jamie]]

Alternatively, we could just fail gracefully for attributes on those text leaves, which is what I was considering for bug 1744150... but that doesn't seem ideal if we know the cause.

Comment 4

[James Teh [:Jamie]]

S4 because behind a disabled pref.

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1747164 - Make HTMLDateTimeAccessible inherit from HyperTextAccessibleWrap. r?morgan

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9081d06a622b
Make HTMLDateTimeAccessible inherit from HyperTextAccessibleWrap. r=morgan

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9081d06a622b