1747178 - Add/move some locking in audio code

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

There are some issues with the locking in AudioStream.h and AudioSink.cpp. In a few cases locking is missing, and in some others the locking is done in the wrong place/too late/not covering some items that should be locked, from what clang thread-safety static analysis tells me. (See blocked bug)

GUARDED_BY/etc annotations used to find these will land later, with support for thread-safety.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1747178: dom/media Audio thread-safety cleanup r=padenot

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1747178 - Make AudioStream::mOutChannel const. r?alwu

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1747178 - Make AudioStream::mOutChannel const. r?alwu

This makes it clear that it's safe to access it from any thread.

Depends on D137182

Comment 5

[Phabricator Automation]

Comment on attachment 9261107 [details]
Bug 1747178 - Make AudioStream::mOutChannel const. r?alwu

Revision D137183 was moved to bug 1752345. Setting attachment 9261107 [details] to obsolete.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

dom/media Audio thread-safety cleanup r=padenot
https://hg.mozilla.org/integration/autoland/rev/7ac87c123f76ca0e6e507be6bfddb187a313fec4
https://hg.mozilla.org/mozilla-central/rev/7ac87c123f76