1747264 - Crash in [@ OOM | large | NS_ABORT_OOM | nsParser::Parse] on register.eshram.gov.in, mostly with 32-bit builds on Windows 7

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Between 30 and 120 crashes per Firefox 96 beta version, mostly with 32-bit builds of Firefox and >70% on Windows 7.

If an url had been submitted for the Firefox 96 beta crashes, it used the host https://register.eshram.gov.in/ which only seems accessible from India (using a VPN worked). The page which links to it is https://eshram.gov.in/ and connections to it work from outside India.

Crash report: https://crash-stats.mozilla.org/report/index/f4d769c0-868c-481d-8bd6-3b15e0211222

MOZ_CRASH Reason: MOZ_CRASH(OOM)

Top 10 frames of crashing thread:

0 xul.dll NS_ABORT_OOM xpcom/base/nsDebugImpl.cpp:616
1 xul.dll nsParser::Parse parser/htmlparser/nsParser.cpp:708
2 xul.dll mozilla::dom::XMLDocument::StartDocumentLoad dom/xml/XMLDocument.cpp:295
3 xul.dll nsContentDLF::CreateInstance layout/build/nsContentDLF.cpp:123
4 xul.dll mozilla::image::SVGDocumentWrapper::OnStartRequest image/SVGDocumentWrapper.cpp:200
5 xul.dll mozilla::image::VectorImage::OnStartRequest image/VectorImage.cpp:1389
6 xul.dll static mozilla::image::ImageFactory::CreateImage image/ImageFactory.cpp:130
7 xul.dll imgRequest::OnDataAvailable image/imgRequest.cpp:968
8 xul.dll ProxyListener::OnDataAvailable image/imgLoader.cpp:3024
9 xul.dll nsCORSListenerProxy::OnDataAvailable netwerk/protocol/http/nsCORSListenerProxy.cpp:657

Comment 1

[Henri Sivonen (:hsivonen)]

XML, not HTML.

I suspect the URL is huge so that the conversion from UTF-8 to UTF-16 OOMs, but the part calling NS_ABORT_OOM has been inlined away.

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1747264 - Avoid OOMing if the URL of an XML document is huge.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/827b488113ac
Avoid OOMing if the URL of an XML document is huge. r=smaug

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/827b488113ac

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Should this be uplifted?

Comment 6

[Henri Sivonen (:hsivonen)]

(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #5)

Should this be uplifted?

Unclear. The risk of uplifting is pretty much zero. However, the benefit probably isn't particularly high. I'll nominate.

Comment 7

[Henri Sivonen (:hsivonen)]

Comment on attachment 9256545 [details]
Bug 1747264 - Avoid OOMing if the URL of an XML document is huge.

Beta/Release Uplift Approval Request

• User impact if declined: OOM crashes
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Turns an existing OOM check from abort to early return.
• String changes made/needed: None

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Extremely low-risk patch to avoid OOM crashes
• User impact if declined: OOM crashes
• Fix Landed on Version: 97
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Turns an existing OOM check from abort to early return.

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9256545 [details]
Bug 1747264 - Avoid OOMing if the URL of an XML document is huge.

Approved for 96.0rc1

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e87307f88680

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9256545 [details]
Bug 1747264 - Avoid OOMing if the URL of an XML document is huge.

Approved for 91.5esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/7580206f912c