1747354 - Building with DIST set to something else than $objdir/dist is busted

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

And it has been for presumably years. Let's just kill it.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1747354 - Remove the DIST configure option.

Setting it to something else than $objdir/dist has been busted for a
very long time because so many things just use $objdir/dist instead of
$DIST.

Moreover, it's cumbersome to use, because being an option that is so
early, it's not settable in a mozconfig. It has to be set in the
environment when running configure.

As apparently no-one has reported this being broken, we just proceed to
remove it.

We do keep the build-system-internal value because some things do use
it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d177669d50e
Remove the DIST configure option. r=firefox-build-system-reviewers,andi

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bbaaedf3a0b
Lint fix. r=fix. CLOSED TREE

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2d177669d50e
https://hg.mozilla.org/mozilla-central/rev/4bbaaedf3a0b