Closed Bug 1747358 Opened 2 years ago Closed 2 years ago

The "about:logins" page cannot be scrolled anymore when it is smaller resized

Categories

(Firefox :: about:logins, defect, P2)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
99 Branch
Tracking Status
firefox95 --- unaffected
firefox96 --- wontfix
firefox97 --- wontfix
firefox98 --- wontfix
firefox99 --- verified

People

(Reporter: srosu, Assigned: serg)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image LackOfScrollbar.gif

[Affected versions]:

  • Nightly 97.0a1 (Build ID: 20211222165857)
  • Beta 96.0b8 (Build ID: 20211221185759)

[Affected Platforms]:

  • Windows 10 x64
  • macOS 11.6
  • Ubuntu 20.04

[Prerequisites]:

  • Have the latest Firefox Nightly/Beta browser installed and opened.

[Steps to reproduce]:

  1. Navigate to the “about:logins” page.
  2. Resize the browser and try to scroll the page.
  3. Observe what happens.

[Expected result]:

  • The page can be scrolled and all the page elements are visible.

[Actual result]:

  • The page cannot be scrolled and some elements are not visible.

[Regression]

  • The issue is not reproducible with the older Nightly 97.0a1 build. Considering this using mozregression tools I have found the regression range. Here are the results:
    Last good revision: f007b3b66bb91d97049fb9ff31ab6cc6aab36fd8
    First bad revision: 2c905815eb29e3ed917093bcafb3cba66ea38f13
    Pushlog: link

From this pushlog it seems that Bug 1745020 introduced this behavior.

[Notes]:

  • Attached is a screen recording of the issue.
Priority: -- → P2
Has Regression Range: --- → yes

Tim, it seems your patch in bug 1745020 caused this regression, could you have a look please? Thanks

Flags: needinfo?(tgiles)

I'll take it

Assignee: nobody → sgalich
Flags: needinfo?(tgiles)
Status: NEW → ASSIGNED
Pushed by sgalich@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/639661d6eb96
The "about:logins" page cannot be scrolled anymore when it is smaller resized. r=tgiles
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch

I‘ve just verified this issue using the latest Firefox Nightly 99.0a1 (Build ID: 20220220215821) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

  • It seems that this issue is still partially reproducible. Even if the page can be scrolled horizontally, it still can't be vertically scrolled, and the elements from the "no logins" screen aren't visible when the browser is resized.

@Sergey, considering these should I mark this issue as Verified and file a new one? Thanks!

Flags: needinfo?(sgalich)

The fix is small and targeted and we have several duplicates of this bug, Sergey do you plan on requesting uplift in our last betas for 98 or do you prefer to let it bake on nightly and ship with 99? Thanks

(In reply to Simona Rosu [:srosu], Ecosystem QA from comment #8)

I‘ve just verified this issue using the latest Firefox Nightly 99.0a1 (Build ID: 20220220215821) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

  • It seems that this issue is still partially reproducible. Even if the page can be scrolled horizontally, it still can't be vertically scrolled, and the elements from the "no logins" screen aren't visible when the browser is resized.

@Sergey, considering these should I mark this issue as Verified and file a new one? Thanks!

Simona, lets file a new one, I suspect this will be easier to track and progress. Thanks!

Flags: needinfo?(sgalich)

(In reply to Pascal Chevrel:pascalc from comment #9)

The fix is small and targeted and we have several duplicates of this bug, Sergey do you plan on requesting uplift in our last betas for 98 or do you prefer to let it bake on nightly and ship with 99? Thanks

Pascal, I think we can wait until 99. This is rather temporary fix, we plan to review whole page again soon to ensure proper scrolling/keyboard support.

Thanks, marking 98 as wontfix then.

Thank you, Sergey for your reply. I logged a different bug (Bug 1757151) for the behavior mentioned in comment 8.

  • Considering this I'm marking this issue as Verified fixed.
Status: RESOLVED → VERIFIED
See Also: → 1757151
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: