1747410 - High frequency devtools/client/storage/test/browser_storage_cookies_navigation.js | A promise chain failed to handle a rejection: this.commands is null - stack: get target@resource://devtools/client/framework/too when Gecko 97 merges to Beta on 2022-01-10

Status: VERIFIED FIXED

(DevTools :: Storage Inspector, defect)

Description

[Norisz Fay [:noriszfay]]

Central-as-beta simulation
How to run these simulations

Failure log:

[task 2021-12-23T12:24:19.856Z] 12:24:19     INFO - TEST-START | devtools/client/storage/test/browser_storage_cookies_navigation.js
[task 2021-12-23T12:24:21.514Z] 12:24:21     INFO - GECKO(3652) | console.warn: "Already started legacy listener for extension-storage on server0.conn13.windowGlobal8589934614/windowGlobalTarget2"
[task 2021-12-23T12:24:21.741Z] 12:24:21     INFO - GECKO(3652) | console.error: (new InvalidStateError("JSWindowActorChild.sendAsyncMessage: JSWindowActorChild cannot send at the moment", (void 0), 327))
[task 2021-12-23T12:24:21.745Z] 12:24:21     INFO - GECKO(3652) | InvalidStateError: JSWindowActorChild.sendAsyncMessage: JSWindowActorChild cannot send at the moment: _createTargetActor/<@resource://devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm:327:12
[task 2021-12-23T12:24:21.745Z] 12:24:21     INFO - GECKO(3652) | newListener@resource://devtools/shared/event-emitter.js:173:27
<...>
[task 2021-12-23T12:24:27.786Z] 12:24:27     INFO - run@chrome://mochikit/content/browser-test.js:1509:9
[task 2021-12-23T12:24:27.786Z] 12:24:27     INFO - 
[task 2021-12-23T12:24:27.787Z] 12:24:27     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2021-12-23T12:24:27.787Z] 12:24:27     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2021-12-23T12:24:27.787Z] 12:24:27     INFO - TEST-PASS | devtools/client/storage/test/browser_storage_cookies_navigation.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2021-12-23T12:24:27.788Z] 12:24:27     INFO - Console message: [JavaScript Error: "TypeError: this.commands is null" {file: "resource://devtools/client/framework/toolbox.js" line: 532}]
[task 2021-12-23T12:24:27.788Z] 12:24:27     INFO - Buffered messages finished
[task 2021-12-23T12:24:27.790Z] 12:24:27     INFO - TEST-UNEXPECTED-FAIL | devtools/client/storage/test/browser_storage_cookies_navigation.js | A promise chain failed to handle a rejection: this.commands is null - stack: get target@resource://devtools/client/framework/toolbox.js:532:5
[task 2021-12-23T12:24:27.790Z] 12:24:27     INFO - _commandIsVisible@resource://devtools/client/framework/toolbox.js:2355:30
[task 2021-12-23T12:24:27.791Z] 12:24:27     INFO - updateFrameButton@resource://devtools/client/framework/toolbox.js:2330:14
[task 2021-12-23T12:24:27.791Z] 12:24:27     INFO - updateUiElements@resource://devtools/client/framework/toolbox.js:3444:12
[task 2021-12-23T12:24:27.792Z] 12:24:27     INFO - _updateFrames@resource://devtools/client/framework/toolbox.js:3456:7
[task 2021-12-23T12:24:27.792Z] 12:24:27     INFO - _onTargetAvailable@resource://devtools/client/framework/toolbox.js:732:12
[task 2021-12-23T12:24:27.792Z] 12:24:27     INFO - Async*_emit@resource://devtools/shared/event-emitter.js:244:34
[task 2021-12-23T12:24:27.793Z] 12:24:27     INFO - emitAsync@resource://devtools/shared/event-emitter.js:194:25
[task 2021-12-23T12:24:27.793Z] 12:24:27     INFO - emitAsync@resource://devtools/shared/event-emitter.js:346:25
[task 2021-12-23T12:24:27.793Z] 12:24:27     INFO - _onTargetAvailable@resource://devtools/shared/commands/target/target-command.js:215:33
[task 2021-12-23T12:24:27.794Z] 12:24:27     INFO - Async*_emit@resource://devtools/shared/event-emitter.js:244:34
[task 2021-12-23T12:24:27.794Z] 12:24:27     INFO - emit@resource://devtools/shared/event-emitter.js:190:18
[task 2021-12-23T12:24:27.794Z] 12:24:27     INFO - emit@resource://devtools/shared/event-emitter.js:342:18
[task 2021-12-23T12:24:27.794Z] 12:24:27     INFO - _onTargetAvailable@resource://devtools/client/fronts/watcher.js:60:10
[task 2021-12-23T12:24:27.794Z] 12:24:27     INFO - _emit@resource://devtools/shared/event-emitter.js:244:34
[task 2021-12-23T12:24:27.794Z] 12:24:27     INFO - emit@resource://devtools/shared/event-emitter.js:190:18
[task 2021-12-23T12:24:27.795Z] 12:24:27     INFO - emit@resource://devtools/shared/event-emitter.js:342:18
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - onPacket@resource://devtools/shared/protocol/Front.js:336:13
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - onPacket@resource://devtools/client/devtools-client.js:482:13
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - send/<@resource://devtools/shared/transport/local-transport.js:68:25
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/DevToolsUtils.js:54:21
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - send@resource://devtools/shared/transport/local-transport.js:56:21
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - send@resource://devtools/server/devtools-server-connection.js:99:20
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - _sendEvent@resource://devtools/shared/protocol/Actor.js:72:15
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - initialize/<@resource://devtools/shared/protocol/Actor.js:46:16
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - _emit@resource://devtools/shared/event-emitter.js:244:34
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - emit@resource://devtools/shared/event-emitter.js:190:18
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - emit@resource://devtools/shared/event-emitter.js:342:18
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - notifyTargetAvailable@resource://devtools/server/actors/watcher.js:321:12
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - connectFromContent@resource://devtools/server/connectors/js-window-actor/DevToolsFrameParent.jsm:145:13
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - receiveMessage@resource://devtools/server/connectors/js-window-actor/DevToolsFrameParent.jsm:211:21
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - JSActor query*_createTargetActor@resource://devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm:350:10
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - instantiate@resource://devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm:245:14
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - handleEvent@resource://devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm:687:12
[task 2021-12-23T12:24:27.796Z] 12:24:27     INFO - Rejection date: Thu Dec 23 2021 12:24:27 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 271
[task 2021-12-23T12:24:27.797Z] 12:24:27     INFO - Stack trace:
[task 2021-12-23T12:24:27.797Z] 12:24:27     INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:271
[task 2021-12-23T12:24:27.797Z] 12:24:27     INFO - chrome://mochikit/content/browser-test.js:nextTest:625
[task 2021-12-23T12:24:27.797Z] 12:24:27     INFO - chrome://mochikit/content/browser-test.js:testScope/test_finish/<:1594
[task 2021-12-23T12:24:27.797Z] 12:24:27     INFO - chrome://mochikit/content/browser-test.js:run:1509
[task 2021-12-23T12:24:27.797Z] 12:24:27     INFO - GECKO(3652) | MEMORY STAT | vsize 20983949MB | residentFast 1575MB
[task 2021-12-23T12:24:27.797Z] 12:24:27     INFO - TEST-OK | devtools/client/storage/test/browser_storage_cookies_navigation.js | took 7601ms
[task 2021-12-23T12:24:27.797Z] 12:24:27     INFO - checking window state
[task 2021-12-23T12:24:27.797Z] 12:24:27     INFO - TEST-START | devtools/client/storage/test/browser_storage_cookies_tab_navigation.js

Comment 1

[Cosmin Sabou [:CosminS]]

Alexandre, could this be from the changes in Bug 1746952?

Comment 2

[Intermittent Failures Robot]

3 failures in 1011 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3

Platform and build breakdown:

• linux1804-64-asan-qr: 1
  • opt: 1
• windows10-64-2004-asan-qr: 1
  • opt: 1
• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1747410&startday=2021-12-27&endday=2022-01-02&tree=all

Comment 3

[Intermittent Failures Robot]

15 failures in 2801 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 15

Platform and build breakdown:

• windows10-64-2004-asan-qr: 7
  • opt: 7
• linux1804-64-asan-qr: 6
  • opt: 6
• linux1804-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1747410&startday=2022-01-03&endday=2022-01-09&tree=all

Comment 4

[Intermittent Failures Robot]

36 failures in 3060 pushes (0.012 failures/push) were associated with this bug in the last 7 days.

This is the #33 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-beta: 27
• try: 9

Platform and build breakdown:

• linux1804-64-asan-qr: 12
  • opt: 12
• windows10-64-2004-asan-qr: 14
  • opt: 14
• linux1804-64-shippable-qr: 10
  • opt: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1747410&startday=2022-01-10&endday=2022-01-16&tree=all

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Nicolas, do you have cycles to look at this? This is very frequently failing test at the moment.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Let's see https://treeherder.mozilla.org/jobs?repo=try&revision=beb9a8fb85e4684795943b1a7f1576b09a1ea723

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

of course there's other intermittent on that test (Bug 1715632), but I'm not seeing the specific failure this bug was opened for

Comment 8

[Intermittent Failures Robot]

45 failures in 3444 pushes (0.013 failures/push) were associated with this bug in the last 7 days.

This is the #25 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-beta: 31
• try: 14

Platform and build breakdown:

• windows10-64-2004-asan-qr: 21
  • opt: 21
• linux1804-64-asan-qr: 16
  • opt: 16
• linux1804-64-shippable-qr: 6
  • opt: 6
• linux1804-64-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1747410&startday=2022-01-17&endday=2022-01-23&tree=all

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1747410 - [devtools] Fix intermittent in browser_storage_cookies_navigation.js . r=jdescottes.

The test was failing because the toolbox was handling a new target
during toolbox destruction. To fix this, we wait for the target
data to be displayed in the storage inspector.

Comment 10

[Cosmin Sabou [:CosminS]]

The patch doesn't seem to be working in beta-sim. Nicholas, could you have another go at this? Thank you.

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

let's try to go for a simpler fix

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6e2ea940c16
[devtools] Fix intermittent in browser_storage_cookies_navigation.js . r=jdescottes.

Comment 13

[Intermittent Failures Robot]

27 failures in 3445 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

This is the #50 most frequent failure this week.

Repository breakdown:

• try: 5
• mozilla-beta: 22

Platform and build breakdown:

• windows10-64-2004-asan-qr: 14
  • opt: 14
• linux1804-64-asan-qr: 9
  • opt: 9
• linux1804-64-shippable-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1747410&startday=2022-01-24&endday=2022-01-30&tree=all

Comment 14

[Norisz Fay [:noriszfay]]

The patch seems to be working as of today's early beta-sim

Comment 15

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e6e2ea940c16

Comment 16

[Cristina Cozmuta (:CrissCozmuta)]

The patch was verified fixed on today's beta-sim

Comment 17

[Intermittent Failures Robot]

5 failures in 3165 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 4
• mozilla-release: 1

Platform and build breakdown:

• linux1804-64-asan-qr: 2
  • opt: 2
• windows10-64-2004-asan-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1747410&startday=2022-01-31&endday=2022-02-06&tree=all

Comment 18

[Intermittent Failures Robot]

5 failures in 3711 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 5

Platform and build breakdown:

• windows10-64-2004-asan-qr: 1
  • opt: 1
• linux1804-64-asan-qr: 2
  • opt: 2
• linux1804-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1747410&startday=2022-02-07&endday=2022-02-13&tree=all

Comment 19

[Intermittent Failures Robot]

10 failures in 3281 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 10

Platform and build breakdown:

• linux1804-64-asan-qr: 6
  • opt: 6
• windows10-64-2004-asan-qr: 3
  • opt: 3
• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1747410&startday=2022-02-14&endday=2022-02-20&tree=all