1747433 - Remove preprocessor use of app menu warning color definitions

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P3)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1747432 +++

This bug covers browser/themes/shared/customizableui/panelUI.inc.css and the various @appmenuWarning*@ variables.

These could just use a CSS variable, I believe.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1747433 - Remove unused appMenuWarning* preprocessor vars, and associated rules in panelUI.inc.css. r?dao!

Comment 2

[Sam Foster [:sfoster] (he/him)]

I've not yet figured out how to verify these changes. Gijs, Do you know where/when the element with the class.fxa-menu-header gets defined?
The tricks I've used previously to fake a bad FxA aren't getting me anything here.

Comment 3

[:Gijs (he/him)]

(In reply to Sam Foster [:sfoster] (he/him) from comment #2)

I've not yet figured out how to verify these changes. Gijs, Do you know where/when the element with the class.fxa-menu-header gets defined?
The tricks I've used previously to fake a bad FxA aren't getting me anything here.

So I looked at blame for the CSS bits, which points to bug 1586075 amongst others. That was in esr78, so I looked for the class in that, which turns up:

https://searchfox.org/mozilla-esr78/rev/3c633b1a0994f380032a616eced632398354d83e/browser/components/customizableui/content/panelUI.inc.xhtml#846

Looking for the same node now, it's in the viewcache file, which got moved out there by the work to help the pine branch. Looking at its previous location, in browser.xhtml: https://hg.mozilla.org/mozilla-central/file/de40c72ddc80133fd7a98fb92293dc8aec7cc9c2/browser/base/content/browser.xhtml and following the log from there: https://hg.mozilla.org/mozilla-central/log/de40c72ddc80133fd7a98fb92293dc8aec7cc9c2/browser/base/content/browser.xhtml?patch=&linerange=1505:1509 turns up bug 1690131, which removed that class. I don't see any discussion there, so I assume this can all just go away? Sorry for not realizing that before!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84a3e3fe804d
Remove unused appMenuWarning* preprocessor vars, and associated rules in panelUI.inc.css. r=dao

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/84a3e3fe804d