1747476 - Properly handle resizing on HTMLCanvasElement/OffscreenCanvas

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

When we use HTMLCanvasElement.transferControlToOffscreen, how the width and height is handled is different. We should be throwing clear invalid state errors for the placeholders for the callers. This impacts WPTs:

https://searchfox.org/mozilla-central/source/testing/web-platform/tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.resize.html

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1747476 - Fix resizing errors with OffscreenCanvas.

When we attempt to resize an OffscreenCanvas, or an HTMLCanvasElement
with transferControlToOffscreen caled on it, we need to ensure we throw
the right error, and a message that is clear to the user. We also need
to propogate size changes to the placeholder
HTMLCanvasElement/OffscreenCanvas, when the OffscreenCanvas object on
the worker thread has its size changed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/189db961e8ed
Fix resizing errors with OffscreenCanvas. r=gfx-reviewers,kvark,mstange

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/189db961e8ed