1747520 - Ensure OffscreenCanvas invalidation is consistent

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

There are some invalidation concerns I have with the current implementation of OffscreenCanvas.

• We actually invalidate more than we need to, by queuing a commit to compositor for every draw call. This should rate limit itself.
• We should cancel any pending commits if an explicit commit call is made (e.g. for OffscreenCanvasRenderingContext2D.commit)
• We should ensure a commit and updating parameters is atomic. Since the parameter update can impact the surface properties, such as alpha, we need to make sure that triggers a commit.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1747520 - Ensure that OffscreenCanvas invalidation is in a consistent state.

This patch ensures that our invalidation is more consistent and less
frequent. It no longer queues an invalidation for each draw call. It now
combines the parameter update (e.g. width, height, opacity) with an
invalidation to ensure the contents of the canvas are consistent with
the advertised properties. It also ensures that if an explicit commit
occurs, any pending commits are cancelled.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bfdd68d590d
Ensure that OffscreenCanvas invalidation is in a consistent state. r=gfx-reviewers,kvark

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9bfdd68d590d