1747816 - Converge to a unique way to designate original source in debugger frontend

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Bug 1603283 introduced isOriginal attribute on all reducer's source objects.
And since then, we started using it here and there:
https://searchfox.org/mozilla-central/search?q=source.isOriginal&path=&case=false&regexp=false
But this is now redundant with the two other old helpers:

• isOriginal:
  https://searchfox.org/mozilla-central/rev/e74a8e2d1dedebfe47a6afb009ddabdeea12694b/devtools/client/debugger/src/utils/source.js#488-492
• isOriginalSource:
  https://searchfox.org/mozilla-central/rev/e74a8e2d1dedebfe47a6afb009ddabdeea12694b/devtools/client/debugger/src/utils/source-maps.js#82-92

Let's try to strick to use the isOriginal attribute everywhere.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1747816 - [devtools] Always use reducer's source's `isOriginal` attribute to know if a source is an original one.

"original" here refers to not being generated.
It overlaps with pretty printed sources, which are considered as original sources.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d00b5ccb5aed
[devtools] Always use reducer's source's `isOriginal` attribute to know if a source is an original one. r=bomsy

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d00b5ccb5aed