1747907 - GeckoView does not receive save credit card prompts when trying to update an existing credit card

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

While testing save credit card dialog on Fenix (note this is only on my local dev), we are not getting a save credit card request if the credit card was autofilled by selecting an existing credit card and changing a field like expiry dates and performing a form submit.

STR (not reproducible unless you were working my local dev on Fenix):

1. Navigate to https://checkout.stripe.dev/preview
2. Autofill an existing credit card information (can also manually enter the existing credit card)
3. Change the expiry date.
4. Perform a form submit.
5. Observe that there is no save credit card prompt where we can figure out whether or not this is an update or save a credit card action.

The implication for Fenix is that we would never ever show an update

I am assuming we are returning early somewhere (maybe because it doesn't recognize any changes or knows that it matches an existing record) prior to calling https://searchfox.org/mozilla-central/source/toolkit/components/formautofill/FormAutofillParent.jsm#713.

This might be related to Bug 1747898, where GeckoView doesn't receive an accurate credit card object, but probably unlikely since FormAutofillParent does some checks prior to calling FormAutofillPrompter.promptToSaveCreditCard

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Chris Peterson [:cpeterson]]

Fenix's credit card autofill feature is blocked waiting for this bug fix.

https://mozilla-hub.atlassian.net/browse/FNXV2-17088

Comment 3

[Dimi Lee [:dimi]]

The patch in Bug 1747898 fixes this issue