1747955 - browser.bookmarks.openInTabClosesMenu is not working

Status: NEW

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[ulomalopn63]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:95.0) Gecko/20100101 Firefox/95.0

Steps to reproduce:

• Create a folder in the bookmarks.
• Fill it with bookmarks.
• Open "about:config".
• Set "browser.bookmarks.openInTabClosesMenu" to "false".
• Open any bookmark.

Rules to which I have changed the original value (just in case):

• browser.tabs.closeWindowWithLastTab=false
• browser.tabs.loadBookmarksInBackground=false
• browser.tabs.loadBookmarksInTabs=true
• browser.tabs.warnOnClose=true

Actual results:

The bookmarks menu closes.

Expected results:

The bookmarks menu should remain open.

Comment 1

[ulomalopn63]

Correction: browser.tabs.loadBookmarksInBackground=true

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Daniel Bodea [:danibodea]]

How exactly do you open a bookmark?
Do you Open the Bookmarks Manager (window named Library?), right-click on a bookmark and click "Open" or "Open in a new tab"?

I imagine you expect that the Bookmark Manager does not go in the background when tabs are opened in the background, is that right?
Please be very clear about your steps so we understand your intended issue correctly.
Thank you for your report!

Comment 4

[ulomalopn63]

(In reply to Bodea Daniel [:danibodea] from comment #3)

How exactly do you open a bookmark?
Do you Open the Bookmarks Manager (window named Library?), right-click on a bookmark and click "Open" or "Open in a new tab"?

I imagine you expect that the Bookmark Manager does not go in the background when tabs are opened in the background, is that right?
Please be very clear about your steps so we understand your intended issue correctly.
Thank you for your report!

Sorry by bad.

• I open them by left-clicking.
• I don't, I open them from the Bookmarks Toolbar.
• When a bookmark is stored in a folder and it's opened with left click from the Bookmarks Toolbar, the expected behavior of this rule when set to false is the same as middle-clicking, Ctrl+left click and right click+Open in new tab, the folder or menu shouldn't close.
• The steps to reproduce are still the same, maybe a small correction in the first step "Create a folder in the Bookmarks Toolbar" and the last one "Open any bookmark from the Bookmarks Toolbar stored in a folder".

Comment 5

[Mark Banner (:standard8)]

Setting as P3/S3. Might be useful to get a regression range for where this was introduced.

Comment 6

[Daniel Bodea [:danibodea]]

It seems to me that the "browser.bookmarks.openInTabClosesMenu" pref only changes the behavior of the middle-click or ctrl+left-click actions as it only makes sense that the left-click alone simply performs the action and closes the menu by default.

Furthermore, I've attempted to find a version where the bookmark folder menu does not close when using left-click (in addition to the mentioned preferences), but they all behave the same (Release v95.0, Release v94.0, Nightly v93.0a1, Release v107.0).

For certainty, this tutorial explains exactly what the pref in question changes and it does not mention left-clicking bookmarks in folders, only middle-clicking and CTRL+left-click:
https://www.askvg.com/firefox-tip-keep-bookmarks-folder-menu-visible-to-open-multiple-bookmarks-in-new-tabs/

Based on the above, I can confirm that this is not a regression and it still behaves as originally designed.
While Mark has thought that this behavior might be important to consider, I will confirm this as an enhancement and people with decision-power could take this into consideration if the approach is valid.