1747969 - Pocket newtab remote layouts descriptions broke

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[Scott [:thecount] Downe]

This is a bug caused by bug 1746649.

Bug 1746649 made it so we could add/remove description via a pref for testing purposes, the default is still on.

Where this went wrong and caused this bug is two fold.

We made the pref default to true, and called it "includeDescriptions"
We didn't consider remote layouts.

When remote layouts try to render, they don't use the standard render stack, and end up not getting the "includeDescriptions" default.

Because we don't want to have to maintain or modify the remote layouts, it probably makes more sense to flip "includeDescriptions" to "hideDescriptions", this way old layouts default state is falsy, and in this case, falsy produces the previous experience.

We should still be able to run our test with "hideDescriptions" just fine, just reversing the logic a bit.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1747969 - Fixing Pocket newtab descriptions for remote layouts.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1746649

Comment 3

[Scott [:thecount] Downe]

Steps to test:

1. Set pref browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
2. Go to about:home#devtools-ds
3. Uncheck "hardcoded_layout"
4. Check "staging_spocs"
5. Open a new tab

Expected: Stories should have descriptions.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a56b41089893
Fixing Pocket newtab descriptions for remote layouts. r=gvn

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a56b41089893