Closed
Bug 1748032
Opened 3 years ago
Closed 3 years ago
QueueWithSizes.clear leaks
Categories
(Core :: DOM: Streams, defect)
Core
DOM: Streams
Tracking
()
RESOLVED
FIXED
98 Branch
| Tracking | Status | |
|---|---|---|
| firefox98 | --- | fixed |
People
(Reporter: evilpies, Assigned: mgaudet)
References
Details
Attachments
(1 file)
We use a LinkedList with every element allocated by new for QueueWithSizes. The base of implementation clear will just call popFirst in a loop. It doesn't look like anything will actually delete the element.
It think in DequeueValue we already use UniquePtr<ValueWithSize> to make similar code work. I think we should look into implementing QueueWithSizes as LinkedList<UniquePtr<ValueWithSize>>.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → mgaudet
Status: NEW → ASSIGNED
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35fb4094af55
Correct, and document, lifetime management of QueueWithSizes elements r=evilpie
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox98:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•