Closed
Bug 1748174
Opened 2 years ago
Closed 2 years ago
Clean-up a bit touch-action code.
Categories
(Core :: Panning and Zooming, task)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
97 Branch
| Tracking | Status | |
|---|---|---|
| firefox97 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Comment 1•2 years ago
|
||
This shouldn't change behavior but makes following the code a bit
easier. There's no point in using callbacks for touch-action as:
- We return the computed flags anyways.
- Each caller wants to do something different.
- (more importantly) The callback gets called synchronously.
So move the relevant code to TouchActionHelper and make the callers deal
with the flags as they please. I've preserved the behavior of only doing
the thing if the flags array is non-empty.
|
|
Assignee | |
Comment 2•2 years ago
|
||
It's been enabled by default since ~forever.
Depends on D134933
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35e5e4ad8520 Clean-up a bit touch-action code. r=hiro
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
|
|
Assignee | |
Comment 5•2 years ago
|
||
Err, another patch needs to land.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3109573f0428 Remove touch-action pref. r=hiro
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•