Closed Bug 1748217 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 32221 - Fix CSS gradient invalidation when currentColor changes.

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox98 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32221 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32221
Details from upstream follow.

Steinar H. Gunderson <sesse@chromium.org> wrote:

Fix CSS gradient invalidation when currentColor changes.

When checking whether to invalidate an item, we check if the old and new
backgrounds are “visually equal” by asking its type. However, gradients
would just check that all stops are specified equally, disregarding that
the old currentColor could be different from the new currentColor.

Thus, add a check that if the background depends on currentColor
(ie., it is a gradient that has currentColor as at least one stop),
and currentColor has changed, we need to invalidate the background.

Fixed: 595467
Change-Id: Ia2434aa90217352408791547f4c03a96265db909
Reviewed-on: https://chromium-review.googlesource.com/3353486
WPT-Export-Revision: bd61c86c8272b70ac223e5cac5de8b3cdc21fc09

Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 3
FAIL: 1

Chrome

FAIL: 4

Safari

PASS: 3
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-backgrounds/background-image-gradient-currentcolor-visited.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/852c8afd56f9
[wpt PR 32221] - Fix CSS gradient invalidation when currentColor changes., a=testonly
https://hg.mozilla.org/integration/autoland/rev/7999b37bde2f
[wpt PR 32221] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/852c8afd56f9
https://hg.mozilla.org/mozilla-central/rev/7999b37bde2f

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.