1748230 - Periodic update script doesn't mark old phabricator revisions as obsolete

Status: VERIFIED FIXED

(Release Engineering :: General, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

When the periodic update script runs, it's supposed to automatically abandon any already-existing revisions that are currently opened:
https://searchfox.org/mozilla-central/source/taskcluster/docker/periodic-updates/scripts/periodic_file_updates.sh#436

This doesn't appear to be working anymore, which leads to situations where two weeks' worth of updates can pile up in Phabricator when people are away and not able to review & land them.

Comment 1

[Julien Cristau [:jcristau]]

Looking at the latest log on beta (https://firefoxci.taskcluster-artifacts.net/OTfjfUyISfOGhIdONkkIbg/0/public/logs/live_backing.log), we see:

++ /usr/bin/arc list
++ grep 'Needs Review'
++ grep -E 'mozilla-beta repo-update'
++ awk 'match($0, /D[0-9]+[^: ]/) { print substr($0, RSTART, RLENGTH)  }'
+ for diff in $($ARC list | grep "Needs Review" | grep -E "${BRANCH} repo-update" | awk 'match($0, /D[0-9]+[^: ]/) { print substr($0, RSTART, RLENGTH)  }')
Removing old request D134868
+ echo '{"transactions": [{"type":"abandon"}], "objectIdentifier": "D134868"}'
+ arc call-conduit differential.revision.edit
{"error":"ERR-CONDUIT-CORE","errorMessage":"ERR-CONDUIT-CORE: Parameter \"transactions\" must contain a list of transaction descriptions, but item with key \"0\" is missing a \"value\" field. Each transaction must have a value field.","response":null}

Comment 2

[Julien Cristau [:jcristau]]

Attachment: Bug 1748230 - fix conduit API error marking old repo-update revisions as abandoned. r?#releng

conduit transactions need both a type and value.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d4ab3d0002e
fix conduit API error marking old repo-update revisions as abandoned. r=releng-reviewers,jmaher DONTBUILD

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2d4ab3d0002e

Comment 5

[Julien Cristau [:jcristau]]

96 can do without this. Maybe we can trigger the hook manually on central to verify things work there before we uplift to esr91.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/763840ede10b

Comment 7

[Julien Cristau [:jcristau]]

Verified on central, D135068 was marked abandoned by the task that submitted https://phabricator.services.mozilla.com/D135150