[QM_TRY] Failures in dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0
Categories
(Core :: Storage: Quota Manager, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | affected |
People
(Reporter: jkrause, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: leave-open)
Attachments
(3 files, 2 obsolete files)
UpgradeSchemaFrom4_0To5_0 has been introduced in Bug 1681300.
| Reporter | ||
Comment 1•4 years ago
|
||
Taken from Attachment 9257342 [details].
Updated•4 years ago
|
Comment 2•4 years ago
|
||
At least NS_ERROR_STORAGE_CONSTRAINT seems to be actionable.
Comment 3•4 years ago
|
||
NS_ERROR_FILE_CORRUPTED should be actionable too, the database can be just deleted in that case. We use this policy during database opening already.
NS_ERROR_FILE_NO_DEVICE_SPACE probably means we hit the quota limit, we can figure out something for that too.
For the NS_ERROR_STORAGE_CONSTRAINT, I'm not sure why we are getting it. Maybe some columns contain null values ?
This is exactly a case where an extended result code (SQLite) would be really helpful.
I know that Jan-Rio is working on enabling the extended codes, but we need something which can be used sooner.
There's already a way for getting last error: https://searchfox.org/mozilla-central/rev/996a2cafe472e9934b8cb91db63050f96d8a59cb/storage/mozStorageConnection.cpp#1815
We can add a similar method that will return extended error codes using sqlite3_extended_errcode() call.
Updated•4 years ago
|
| Reporter | ||
Comment 4•4 years ago
|
||
Taken from Attachment 9257839 [details].
| Reporter | ||
Comment 5•4 years ago
|
||
Taken from Attachment 9258408 [details].
Comment 6•4 years ago
|
||
Comment 7•4 years ago
|
||
(In reply to Jan Varga [:janv] from comment #3)
NS_ERROR_FILE_NO_DEVICE_SPACE probably means we hit the quota limit, we can figure out something for that too.
So we could increase the quota limit on our side?
Another remedy would be to migrate in pieces but then it might be necessary commit the transaction for the previous upgrades, and start a new one.
Comment 8•4 years ago
|
||
We could try to disabled quota checks like we do here:
https://searchfox.org/mozilla-central/rev/7271a078fa0c1b858a52614ea60ac82fdd8b3d23/dom/indexedDB/ActorsParent.cpp#10202
The problem is that the cleanup transaction is only allowed to remove data, so once everything is done, we expect that the file on disk is smaller.
However, LS doesn't track physical size, it only tracks logical size (key size + value size), so I just realized that we can't get a quota exceeded error during execution of SQL queries. So it's likely that NS_ERROR_FILE_NO_DEVICE_SPACE is a problem with disk space for real.
Comment 9•4 years ago
•
|
||
(In reply to Jan Varga [:janv] from comment #3)
NS_ERROR_FILE_NO_DEVICE_SPACE probably means we hit the quota limit, we can figure out something for that too.
I assume you refer to this NS_ERROR_FILE_NO_DEVICE_SPACE ? We have the same check also for cache, is this hit from time to time, too?
I'd probably prefer to have a dedicated NS_ERROR_QUOTA_EXCEEDED or something here, at least that is what I understand from those checks.
Comment 10•4 years ago
|
||
No, those NS_ERROR_FILE_NO_DEVICE_SPACE errors are returned from our code to match what mozStorage returns in such situations. What we see in this bug are NS_ERROR_FILE_NO_DEVICE_SPACE errors returned from mozStorage, for example https://hg.mozilla.org/mozilla-central/annotate/09808a64bedd5aa00771ee1c8b73cf11d42a5077/dom/localstorage/ActorsParent.cpp#l440
In mozStorage, it all starts with SQLITE_FULL
https://searchfox.org/mozilla-central/rev/7271a078fa0c1b858a52614ea60ac82fdd8b3d23/storage/TelemetryVFS.cpp#251
https://searchfox.org/mozilla-central/rev/7271a078fa0c1b858a52614ea60ac82fdd8b3d23/storage/mozStoragePrivateHelpers.cpp#60
The LS and Cache example you mentioned are special cases when usage is not tracked by VFS module in mozStorage or special file stream implementations. We have to manually create NS_ERROR_FILE_NO_DEVICE_SPACE there.
The LS case is about tracking logical usage as I mentioned in my previous comment and the Cache case is about the artificial padding.
NS_ERROR_FILE_NO_DEVICE_SPACE is mapped to a final error code before it gets to content:
https://searchfox.org/mozilla-central/rev/7271a078fa0c1b858a52614ea60ac82fdd8b3d23/dom/indexedDB/ActorsParent.cpp#527
https://searchfox.org/mozilla-central/rev/7271a078fa0c1b858a52614ea60ac82fdd8b3d23/dom/indexedDB/ActorsParent.cpp#527
Comment 11•4 years ago
•
|
||
Thanks for the pointers. IIUC still the clamping here and the ambiguity before makes it impossible to distinguish between:
- cases where our quota limit is the boundary we hit (which we can change or could even give the user a hint how to change)
- cases where the underlying disk (database) is physically full (where we cannot do anything but tell the user)
?
But this might well be off-topic here.
Comment 12•4 years ago
|
||
(In reply to Jens Stutte [:jstutte] from comment #11)
Thanks for the pointers. IIUC still the clamping here and the ambiguity before makes it impossible to distinguish between:
- cases where our quota limit is the boundary we hit (which we can change or could even give the user a hint how to change)
- cases where the underlying disk (database) is physically full (where we cannot do anything but tell the user)
?
You are right in general, but in this concrete case when we know that mozStorage databases used by LSNG are not limited by quota at mozStorage level,NS_ERROR_FILE_NO_DEVICE_SPACEreturned from mozStorage can't be triggered by our quota checks. LSNG handles quota at a higher level, it tracks logical size (key size + value size). So our quota checks are done before a database operation is executed.
Anyway, it would be good to remove the ambiguity. Even SQLite uses the same error code for both cases it seems. It's SQLITE_FULL.
So we would have to start with adding SQLITE_QUOTA to SQLite.
| Reporter | ||
Comment 13•4 years ago
|
||
Taken from Attachment 9258943 [details].
| Reporter | ||
Comment 14•4 years ago
|
||
Taken from Attachment 9259422 [details].
Updated•4 years ago
|
Comment 15•4 years ago
|
||
The bug occurs reproducibly when clixo.com website loads, when the site creates an empty shopping cart.
Enabling tracing for prepared statements revealed that the constraint violations are coming from the value field, apparently empty values convert to null blobs. Dropping the constraint fixed the issue.
The fix has potentially impact on 1749007 where the total usage per origin and the total length of stored items disagree. If the error on insert is not propagated, the two values might end up disagreeing.
Comment 16•4 years ago
|
||
Does this mean we do UpgradeSchemaFrom4_0To5_0 each time we create an empty shopping cart on that site? That sounds weird.
Comment 17•4 years ago
|
||
(In reply to Jens Stutte [:jstutte] from comment #16)
Does this mean we do
UpgradeSchemaFrom4_0To5_0each time we create an empty shopping cart on that site? That sounds weird.
Well no, the constraint failure was from line https://searchfox.org/mozilla-central/rev/8d108a59d067ce37671090b0b1972ee8adfb7196/dom/localstorage/ActorsParent.cpp#3647
Admittedly, there is a chance that this and the UpgradeSchemaFrom4_0To5_0 are different. They would be the same though if the conversion of the empty strings to null blobs were the only source of constraint violations.
Comment 18•4 years ago
|
||
Depends on D135597
| Reporter | ||
Comment 19•4 years ago
|
||
Taken from Attachment 9259961 [details].
Comment 20•4 years ago
|
||
Depends on D136393
| Reporter | ||
Comment 21•4 years ago
|
||
Taken from Attachment 9260423 [details].
Comment 22•4 years ago
|
||
Comment on attachment 9258461 [details]
Bug 1748260 - Allow null blobs to avoid constraint violations. r=#dom-storage-reviewers
Revision D135597 was moved to bug 1752265. Setting attachment 9258461 [details] to obsolete.
| Reporter | ||
Comment 23•4 years ago
|
||
Taken from Attachment 9261099 [details].
| Reporter | ||
Comment 24•4 years ago
|
||
Taken from Attachment 9261549 [details].
| Reporter | ||
Comment 25•4 years ago
|
||
Taken from Attachment 9262116 [details].
Comment 26•4 years ago
|
||
Sqlite ALTER TABLE statement documentation makes recommendations under
section about making other kinds of table schema changes.
| Reporter | ||
Comment 27•4 years ago
|
||
Taken from Attachment 9262645 [details].
| Reporter | ||
Comment 28•4 years ago
|
||
Taken from Attachment 9263325 [details].
| Reporter | ||
Comment 29•4 years ago
|
||
Taken from Attachment 9263751 [details].
| Reporter | ||
Comment 30•4 years ago
|
||
Taken from Attachment 9264398 [details].
| Reporter | ||
Comment 31•4 years ago
|
||
Taken from Attachment 9264854 [details].
| Reporter | ||
Comment 32•4 years ago
|
||
Taken from Attachment 9265394 [details].
| Reporter | ||
Comment 33•4 years ago
|
||
Taken from Attachment 9265725 [details].
| Reporter | ||
Comment 34•4 years ago
|
||
Taken from Attachment 9266276 [details].
| Reporter | ||
Comment 35•4 years ago
|
||
Taken from Attachment 9267194 [details].
Updated•4 years ago
|
Updated•4 years ago
|
| Reporter | ||
Comment 36•4 years ago
|
||
Taken from Attachment 9267680 [details].
Comment 37•4 years ago
|
||
Comment 38•4 years ago
|
||
| bugherder | ||
| Reporter | ||
Comment 39•4 years ago
|
||
Taken from Attachment 9268245 [details].
| Reporter | ||
Comment 40•4 years ago
|
||
Taken from Attachment 9268673 [details].
| Reporter | ||
Comment 41•4 years ago
|
||
Taken from Attachment 9269234 [details].
| Reporter | ||
Comment 42•4 years ago
|
||
Taken from Attachment 9269668 [details].
Updated•4 years ago
|
Updated•4 years ago
|
Comment 43•4 years ago
|
||
I would like to use the transaction helper of D136501 to support migrations of Bug 1747102. During migrations, memory usage jumps up and performing the operation in smaller transactions is supposed to help with that. We know from previous experience that memory usage is an issue for a migrations of this type.
| Reporter | ||
Comment 44•4 years ago
|
||
Taken from Attachment 9270720 [details].
| Reporter | ||
Comment 45•4 years ago
|
||
Taken from Attachment 9273265 [details].
| Reporter | ||
Comment 46•4 years ago
|
||
Taken from Attachment 9273630 [details].
| Reporter | ||
Comment 47•4 years ago
|
||
Taken from Attachment 9274230 [details].
| Reporter | ||
Comment 48•4 years ago
|
||
Taken from Attachment 9274666 [details].
| Reporter | ||
Comment 49•4 years ago
|
||
Taken from Attachment 9275142 [details].
| Reporter | ||
Comment 50•4 years ago
|
||
Taken from Attachment 9277802 [details].
| Reporter | ||
Comment 51•4 years ago
|
||
Taken from Attachment 9278772 [details].
| Reporter | ||
Comment 52•4 years ago
|
||
Taken from Attachment 9279436 [details].
| Reporter | ||
Comment 53•4 years ago
|
||
Taken from Attachment 9280502 [details].
| Reporter | ||
Comment 54•4 years ago
|
||
Taken from Attachment 9281030 [details].
| Reporter | ||
Comment 55•4 years ago
|
||
Taken from Attachment 9281654 [details].
| Reporter | ||
Comment 56•4 years ago
|
||
Taken from Attachment 9282062 [details].
| Reporter | ||
Comment 57•4 years ago
|
||
Taken from Attachment 9282574 [details].
| Reporter | ||
Comment 58•4 years ago
|
||
Taken from Attachment 9283105 [details].
| Reporter | ||
Comment 59•4 years ago
|
||
Taken from Attachment 9283698 [details].
| Reporter | ||
Comment 60•4 years ago
|
||
Taken from Attachment 9284043 [details].
| Reporter | ||
Comment 61•4 years ago
|
||
Taken from Attachment 9284542 [details].
| Reporter | ||
Comment 62•4 years ago
|
||
Taken from Attachment 9284944 [details].
| Reporter | ||
Comment 63•4 years ago
|
||
Taken from Attachment 9285537 [details].
| Reporter | ||
Comment 64•4 years ago
|
||
Taken from Attachment 9285884 [details].
| Reporter | ||
Comment 65•4 years ago
|
||
Taken from Attachment 9286416 [details].
| Reporter | ||
Comment 66•4 years ago
|
||
Taken from Attachment 9286902 [details].
| Reporter | ||
Comment 67•4 years ago
|
||
Taken from Attachment 9287513 [details].
| Reporter | ||
Comment 68•4 years ago
|
||
Taken from Attachment 9287946 [details].
| Reporter | ||
Comment 69•4 years ago
|
||
Taken from Attachment 9288807 [details].
| Reporter | ||
Comment 70•4 years ago
|
||
Taken from Attachment 9289456 [details].
| Reporter | ||
Comment 71•4 years ago
|
||
Taken from Attachment 9289898 [details].
| Reporter | ||
Comment 72•4 years ago
|
||
Taken from Attachment 9290471 [details].
| Reporter | ||
Comment 73•4 years ago
|
||
Taken from Attachment 9290912 [details].
| Reporter | ||
Comment 74•4 years ago
|
||
Taken from Attachment 9295314 [details].
| Reporter | ||
Comment 75•4 years ago
|
||
Taken from Attachment 9295797 [details].
| Reporter | ||
Comment 76•4 years ago
|
||
Taken from Attachment 9297480 [details].
| Reporter | ||
Comment 77•4 years ago
|
||
Taken from Attachment 9297844 [details].
| Reporter | ||
Comment 78•4 years ago
|
||
Taken from Attachment 9298458 [details].
| Reporter | ||
Comment 79•4 years ago
|
||
Taken from Attachment 9298856 [details].
| Reporter | ||
Comment 80•3 years ago
|
||
Taken from Attachment 9299546 [details].
| Reporter | ||
Comment 81•3 years ago
|
||
Taken from Attachment 9299914 [details].
Comment 82•3 years ago
|
||
| Reporter | ||
Comment 83•3 years ago
|
||
Taken from Attachment 9300634 [details].
| Reporter | ||
Comment 84•3 years ago
|
||
Taken from Attachment 9302351 [details].
| Reporter | ||
Comment 85•3 years ago
|
||
Taken from Attachment 9302903 [details].
| Reporter | ||
Comment 86•3 years ago
|
||
Taken from Attachment 9305591 [details].
| Reporter | ||
Comment 87•3 years ago
|
||
Taken from Attachment 9306265 [details].
| Reporter | ||
Comment 88•3 years ago
|
||
Taken from Attachment 9306704 [details].
| Reporter | ||
Comment 89•3 years ago
|
||
Taken from Attachment 9307367 [details].
| Reporter | ||
Comment 90•3 years ago
|
||
Taken from Attachment 9307872 [details].
| Reporter | ||
Comment 91•3 years ago
|
||
Taken from Attachment 9308591 [details].
| Reporter | ||
Comment 92•3 years ago
|
||
Taken from Attachment 9309026 [details].
| Reporter | ||
Comment 93•3 years ago
|
||
Taken from Attachment 9310408 [details].
| Reporter | ||
Comment 94•3 years ago
|
||
Taken from Attachment 9310882 [details].
| Reporter | ||
Comment 95•3 years ago
|
||
Taken from Attachment 9311415 [details].
| Reporter | ||
Comment 96•3 years ago
|
||
Taken from Attachment 9312024 [details].
| Reporter | ||
Comment 97•3 years ago
|
||
Taken from Attachment 9312489 [details].
| Reporter | ||
Comment 98•3 years ago
|
||
Taken from Attachment 9313090 [details].
| Reporter | ||
Comment 99•3 years ago
|
||
Taken from Attachment 9313615 [details].
| Reporter | ||
Comment 100•3 years ago
|
||
Taken from Attachment 9314312 [details].
| Reporter | ||
Comment 101•3 years ago
|
||
Taken from Attachment 9314916 [details].
| Reporter | ||
Comment 102•3 years ago
|
||
Taken from Attachment 9315661 [details].
| Reporter | ||
Comment 103•3 years ago
|
||
Taken from Attachment 9316186 [details].
| Reporter | ||
Comment 104•3 years ago
|
||
Taken from Attachment 9316847 [details].
| Reporter | ||
Comment 105•3 years ago
|
||
Taken from Attachment 9317374 [details].
| Reporter | ||
Comment 106•3 years ago
|
||
Taken from Attachment 9318259 [details].
| Reporter | ||
Comment 107•3 years ago
|
||
Taken from Attachment 9318809 [details].
| Reporter | ||
Comment 108•3 years ago
|
||
Taken from Attachment 9319539 [details].
| Reporter | ||
Comment 109•3 years ago
|
||
Taken from Attachment 9320070 [details].
| Reporter | ||
Comment 110•3 years ago
|
||
Taken from Attachment 9320833 [details].
| Reporter | ||
Comment 111•3 years ago
|
||
Taken from Attachment 9321444 [details].
| Reporter | ||
Comment 112•3 years ago
|
||
Taken from Attachment 9322175 [details].
| Reporter | ||
Comment 113•3 years ago
|
||
Taken from Attachment 9322825 [details].
| Reporter | ||
Comment 114•3 years ago
|
||
Taken from Attachment 9323514 [details].
| Reporter | ||
Comment 115•3 years ago
|
||
Taken from Attachment 9324015 [details].
| Reporter | ||
Comment 116•3 years ago
|
||
Taken from Attachment 9326618 [details].
| Reporter | ||
Comment 117•3 years ago
|
||
Taken from Attachment 9327398 [details].
| Reporter | ||
Comment 118•3 years ago
|
||
Taken from Attachment 9328430 [details].
| Reporter | ||
Comment 119•3 years ago
|
||
Taken from Attachment 9328883 [details].
| Reporter | ||
Comment 120•3 years ago
|
||
Taken from Attachment 9329578 [details].
| Reporter | ||
Comment 121•3 years ago
|
||
Taken from Attachment 9330041 [details].
| Reporter | ||
Comment 122•3 years ago
|
||
Taken from Attachment 9330695 [details].
| Reporter | ||
Comment 123•3 years ago
|
||
Taken from Attachment 9331624 [details].
| Reporter | ||
Comment 124•3 years ago
|
||
Taken from Attachment 9332214 [details].
| Reporter | ||
Comment 125•3 years ago
|
||
Taken from Attachment 9333054 [details].
| Reporter | ||
Comment 126•3 years ago
|
||
Taken from Attachment 9333723 [details].
| Reporter | ||
Comment 127•3 years ago
|
||
Taken from Attachment 9335281 [details].
| Reporter | ||
Comment 128•3 years ago
|
||
Taken from Attachment 9335911 [details].
Updated•3 years ago
|
Updated•3 years ago
|
| Reporter | ||
Comment 129•3 years ago
|
||
Taken from Attachment 9337025 [details].
Comment 130•3 years ago
|
||
| Reporter | ||
Comment 131•3 years ago
|
||
Taken from Attachment 9337485 [details].
Comment 132•3 years ago
|
||
| bugherder | ||
Comment 133•3 years ago
|
||
Comment 134•3 years ago
|
||
| bugherder | ||
| Reporter | ||
Comment 135•3 years ago
|
||
Taken from Attachment 9338101 [details].
Comment 136•3 years ago
|
||
Patch D136393 has not yet reached the release.
| Reporter | ||
Comment 137•3 years ago
|
||
Taken from Attachment 9338672 [details].
| Reporter | ||
Comment 138•3 years ago
|
||
Taken from Attachment 9339355 [details].
| Reporter | ||
Comment 139•3 years ago
|
||
Taken from Attachment 9339875 [details].
| Reporter | ||
Comment 140•3 years ago
|
||
Taken from Attachment 9340543 [details].
| Reporter | ||
Comment 141•3 years ago
|
||
Taken from Attachment 9340954 [details].
Comment 142•3 years ago
•
|
||
Looks like NS_ERROR_FILE_CORRUPTED is no longer reported, so D136393 seems to work.
| Reporter | ||
Comment 143•3 years ago
|
||
Taken from Attachment 9341785 [details].
| Clients | Sessions | Hits | Anchor (Context) | Stack |
|---|---|---|---|---|
| 1 | 2 | 2 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#454:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#595:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#7050:NS_ERROR_STORAGE_CONSTRAINT |
| 1 | 2 | 2 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#454:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#595:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#7050:NS_ERROR_STORAGE_CONSTRAINT |
| Reporter | ||
Comment 144•3 years ago
|
||
Taken from Attachment 9342595 [details].
| Clients | Sessions | Hits | Anchor (Context) | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#454:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#595:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#7050:NS_ERROR_STORAGE_CONSTRAINT |
Updated•3 years ago
|
| Reporter | ||
Comment 145•3 years ago
|
||
Taken from Attachment 9344893 [details].
| Clients | Sessions | Hits | Anchor (Context) | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#454:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#595:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#7050:NS_ERROR_STORAGE_CONSTRAINT |
Comment 146•2 years ago
|
||
Taken from Attachment 9361027 [details]
| Clients | Sessions | Hits | Anchor (Context) | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#454:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#595:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#7043:NS_ERROR_STORAGE_CONSTRAINT |
Comment 147•2 years ago
|
||
Taken from Attachment 9362143 [details]
| Clients | Sessions | Hits | Anchor (Context) | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#454:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#595:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#688:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#7043:NS_ERROR_STORAGE_CONSTRAINT |
Comment 148•2 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:smaug, maybe it's time to close this bug?
For more information, please visit BugBot documentation.
Updated•2 years ago
|
Comment 149•2 years ago
|
||
Considering that the current schema version is version 26 it is likely that this anchor will not be hit again in any reasonable timeframe. Still, I would like to make the decision up to @jstutte to close this one.
Comment 150•2 years ago
|
||
@janv is it okay to mark this one as closed? @jstutte said, this is your authority.
Comment 151•2 years ago
|
||
(In reply to Michael van Straten from comment #150)
@janv is it okay to mark this one as closed? @jstutte said, this is your authority.
Our current schema version is 5.0, so this seems to be still relevant.
Comment 152•2 years ago
|
||
Sorry for the confusion, I was looking at the IndexedDB schema version.
Comment 153•2 years ago
|
||
Taken from Attachment 9410559 [details]
| Clients | Sessions | Hits | Anchor (Context) | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#446:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/localstorage/ActorsParent.cpp#596:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/localstorage/ActorsParent.cpp#689:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/localstorage/ActorsParent.cpp#689:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/localstorage/ActorsParent.cpp#7033:NS_ERROR_FILE_NO_DEVICE_SPACE |
Comment 154•1 year ago
|
||
Taken from Attachment 9446236 [details]
| Clients | Sessions | Hits | Anchor (Context) | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#462:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#603:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#7133:NS_ERROR_STORAGE_CONSTRAINT |
Comment 155•1 year ago
|
||
Taken from Attachment 9460752 [details]
| Clients | Sessions | Hits | Anchor (Context) | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#462:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#603:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#7133:NS_ERROR_STORAGE_CONSTRAINT |
| 1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#462:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#603:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#7133:NS_ERROR_STORAGE_CONSTRAINT |
Comment 156•1 year ago
|
||
Taken from Attachment 9464155 [details]
| Clients | Sessions | Hits | Anchor (Context) | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#453:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/localstorage/ActorsParent.cpp#603:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/localstorage/ActorsParent.cpp#7149:NS_ERROR_FILE_NO_DEVICE_SPACE |
Comment 157•1 year ago
|
||
Taken from Attachment 9468632 [details]
| Clients | Sessions | Hits | Anchor (Context) | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#462:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#603:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#7149:NS_ERROR_STORAGE_CONSTRAINT |
| 1 | 1 | 1 | dom/localstorage/ActorsParent.cpp:UpgradeSchemaFrom4_0To5_0 (dom::localstorage::FirstOriginInitializationAttempt::Datastore) | dom/localstorage/ActorsParent.cpp#462:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#603:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#696:NS_ERROR_STORAGE_CONSTRAINT <- dom/localstorage/ActorsParent.cpp#7149:NS_ERROR_STORAGE_CONSTRAINT |
Description
•