Closed Bug 1748262 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 32229 - Fix the fundamental compositing bug for video

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox98 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32229 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32229
Details from upstream follow.

Philip Rogers <pdr@chromium.org> wrote:

Fix the fundamental compositing bug for video

Compositing should not affect the paint order of video. This patch
changes LayoutMedia to not force a PaintLayer, which caused videos to
draw after non-stacked siblings. PaintLayer is now primarily used for
stacking contexts. A PaintLayer was previously required to support
accelerated videos. CompositeAfterPaint changed the compositing
algorithm to work based on display items and property trees, rather
than PaintLayer, which lets us fix this longstanding bug.

The following new WPT test demonstrates the progression:
wpt/css/CSS2/normal-flow/video-paint-order.html

Bug: 370604
Change-Id: Ic9348c4c5b5357b0a920943894be641c3f4928f4
Reviewed-on: https://chromium-review.googlesource.com/3364406
WPT-Export-Revision: ac313e064a18b77dae26227a950a0c1f9d74802e

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/332983f6e28b
[wpt PR 32229] - Fix the fundamental compositing bug for video, a=testonly

https://hg.mozilla.org/mozilla-central/rev/332983f6e28b

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.