1748383 - In configure, make e.g. os.path.join mean the same thing whether importing os or not

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1748383 - In configure, make e.g. os.path.join mean the same thing whether importing os or not.

Currently, using any of the functions defined in
ConfigureSandbox.OS.path in a @depends function will have a different
behavior if the function has an @imports("os") or not. In the former
case, we get plain os.path.$function, while in the latter we get the
function from ConfigureSandbox.OS.path, which handles path separators
differently, which makes a significant difference on Windows.

With this change, we now consistently use the versions from
ConfigureSandbox.OS.path.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2aa8dae914d
In configure, make e.g. os.path.join mean the same thing whether importing os or not. r=firefox-build-system-reviewers,mhentges

Comment 3

[Marian-Vasile Laza]

Backed out changeset c2aa8dae914d (Bug 1748383) for causing python test failures.
Backout link
Push with failures
Failure Log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0da39da3f645
In configure, make e.g. os.path.join mean the same thing whether importing os or not. r=firefox-build-system-reviewers,mhentges

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0da39da3f645