Closed
Bug 1748383
Opened 2 years ago
Closed 2 years ago
In configure, make e.g. os.path.join mean the same thing whether importing os or not
Categories
(Firefox Build System :: General, task)
Firefox Build System
General
Tracking
(firefox97 fixed)
RESOLVED
FIXED
97 Branch
Tracking | Status | |
---|---|---|
firefox97 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•2 years ago
|
||
Currently, using any of the functions defined in
ConfigureSandbox.OS.path
in a @depends
function will have a different
behavior if the function has an @imports("os")
or not. In the former
case, we get plain os.path.$function
, while in the latter we get the
function from ConfigureSandbox.OS.path
, which handles path separators
differently, which makes a significant difference on Windows.
With this change, we now consistently use the versions from
ConfigureSandbox.OS.path
.
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/c2aa8dae914d In configure, make e.g. os.path.join mean the same thing whether importing os or not. r=firefox-build-system-reviewers,mhentges
Comment 3•2 years ago
|
||
Backed out changeset c2aa8dae914d (Bug 1748383) for causing python test failures.
Backout link
Push with failures
Failure Log
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/0da39da3f645 In configure, make e.g. os.path.join mean the same thing whether importing os or not. r=firefox-build-system-reviewers,mhentges
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(mh+mozilla)
Comment 5•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•