1748411 - Bottom of extension popup cut off; lacks scroll bar

Status: NEW

(WebExtensions :: Untriaged, defect, P3)

Description

[grunau]

Attachment: Screenshot 2022-01-04 at 11.01.20.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36

Steps to reproduce:

Adjust the browser window so it has a short height and move it close to the bottom of the screen, then open an extension popup. Or open the extension popup on a screen which is shorter than the height of the extension.

Actual results:

The bottom of the extension popup is cut off.

Expected results:

In Chrome, the same steps produce an extension popup with a scrollbar, so the overflowing extension content can be scrolled. Would like to see the same behaviour in Firefox.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Alex Cornestean]

Hello,

I reproduced the issue on the latest Nightly (97.0a1/20220105170324), Beta (96.0/20220103221059) and Release (95.0.2/20211218203254) under Windows 10 x64 and Ubuntu 16.04 LTS, using the Sporran extension, as in the original report.

When the browser window is resized to have a shorter height than the add-on pop-up and moved to the bottom of the screen, the pop-up will be cut off at the bottom. No scrollbar is available to uncover the content of the pop-up.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Tomislav Jovanovic :zombie]

I had trouble reproducing this since popup needs to be larger than half of screen height, or otherwise it can be opened above the toolbar button.

I guess one of the redesigns (possibly Proton) changed how popups near the limits are sized and now it clashes with extension popups.

A regression range here would probably be useful to see what it might be related to.

Comment 5

[Alex Cornestean]

Hello,

I tried several bisections from early 2019 until the present and then focusing around the time Proton got implemented (so checked for regressions from FX87 until today) and all builds seem to be bad. The last attempt produced one regressor which most likely is incorrect:
2022-02-01T11:12:48.001000: DEBUG : Found commit message:
Bug 1699950 - mozlint/flake8: also update autopep8 r=linter-reviewers,marco DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D109234

2022-02-01T11:12:48.001000: DEBUG : Did not find a branch, checking all integration branches
2022-02-01T11:12:48.002000: INFO : The bisection is done.
2022-02-01T11:12:48.003000: INFO : Stopped

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0ffa44e9a1e2631c5081b8ae8beeaf6b51bf73fa&tochange=08e105d93dfac25d9c459f607946af0afb94b3b6

However, while I was checking the pop-up behavior of the Sporran extension, I was checking the same for uBlock Origin, on the same version I was bisecting. I noticed that while the Sporran pop-up refused to open above the button, the uBlock Origin pop-up opened above the button with no issues.
At this point I think it’s more of a Sporran extension issue than one with the browser.

Comment 6

[Alex Cornestean]

Hello and sorry for the spam.

Tried several new bisections between Firefox 87 and 89 while using an older version of the Sporran add-on (v. 2021.11.17) instead of the latest one available.

With this add-on version, the pop-up was opened above the button ~30% of times, the rest, below the button. This was under the same circumstances i.e. same window height.
When the pop-up was displayed below the button, it was always cut-off and no scroll bar was present.

This time, another regressor was found:
2022-02-02T15:54:41.931000: DEBUG : Found commit message:
Bug 1662614 - Disable browser_stop_control_after_media_reaches_to_end.js on Linux for frequent failures. r=intermittent-reviewers,jmaher

Differential Revision: https://phabricator.services.mozilla.com/D105862

2022-02-02T15:54:41.931000: DEBUG : Did not find a branch, checking all integration branches
2022-02-02T15:54:41.932000: INFO : The bisection is done.
2022-02-02T15:54:41.933000: INFO : Stopped

Comment 7

[Tomislav Jovanovic :zombie]

That test change is unlikely to be the cause of the regression, but it might be intermittent and thus hard to find via moz-regression.

Comment 8

[Alex]

Any news?