1748464 - No tooltips displayed on infobar buttons, e.g., "Dismiss" from "More From Mozilla" or "Take Survey" for "Migration Survey"

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: 2022-01-04_17h40_14.gif

[Affected versions]:

• Firefox RC 96.0 - Build ID: 20220103221059

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6.1
• Linux Mint 20.2 Cinnamon

[Prerequisites]:

• Have the latest Firefox Release 96.0 en-* locale installed.
• Have the "browser.search.region" pref set to "US" in the "about:config" page.
• Have the "user.js" file saved to your PC.
• The browser is set as default.

[Steps to reproduce]:

1. Create a new profile but do not open it.
2. Navigate to the previously created profile folder and paste the "user.js" file from prerequisites.
3. Open the browser with the recently created profile and restart it.
4. Hover the "Dismiss" button from the right part of the "More From Mozilla" infobar.
5. Observe the behavior.

[Expected result]:

• A tooltip is displayed.

[Actual result]:

• There is no tooltip displayed.

[Notes]:

• This issue is also reproducible on the "Treatment B" branch of the experiment.
• Attached a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

This is expected with current design of infobar and not specific to MfM Fx96. See attached similar behavior for restore browser session infobar

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Browser restore Session infobar

Comment 3

[Punam Dahiya [:pdahiya]]

Not sure if there is an existing enhancement request filed for infobar , if not we can repurpose this bug for triage and fixing tooltip on Dismiss

Comment 4

[Punam Dahiya [:pdahiya]]

NI @ryan for UX take on the issue reported. Thanks

Comment 5

[Ryan Casey]

checking with design systems team before updating UI.

Comment 6

[katieC]

Design Systems // UX + Accessibility Recommendation
Always include a tooltip on button icons (see examples in toolbar : app menu, bookmark, pocket, etc)

The "x" icon in the the infobar was originally spec'd (with an accessibility team review) to have a tooltip on hover. Confirming with the Content Team for recommended string "close" vs. "dismiss" (and localization), though perhaps existing infobars can be used as reference?

Comment 7

[Betsy Mikel [:betsymi]]

I am looking into the hover tooltip string and will get back as soon as I have an answer.

Is there any opportunity to change the rest of strings? The new strings we'd like are:

Want more from Mozilla? Check out other products that support a healthy internet. [ View more ]

Comment 8

[Meridel [:meridel]]

Betsy and I discussed. We are partial to "Close" here, rather than "Dismiss" because "Close" is a bit plainer language, less formal. "Dismiss" can also imply that the message will resurface, but this won't necessarily happen as infobar messages are often contextual.

Flod, are there any localization considerations between the options of "Close" and "Dismiss"?

Comment 9

[Meridel [:meridel]]

Morgan, was there an accessibility consideration? Katie mentioned your comment about using "Dismiss."

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Meridel [:meridel] from comment #8)

Flod, are there any localization considerations between the options of "Close" and "Dismiss"?

No, to the point that some locales sometimes translate "Dismiss" as "Close", so they're effectively interchangeable for them.

For example, Microsoft glossary entry in Italian for "dismiss" includes several translations (the equivalent of close, ignore, delete).
https://www.microsoft.com/it-it/language/Search?&searchTerm=dismiss&langID=408&Source=true&productid=undefined

Comment 11

[Punam Dahiya [:pdahiya]]

(In reply to Betsy Mikel [:betsymi] from comment #7)

I am looking into the hover tooltip string and will get back as soon as I have an answer.

Is there any opportunity to change the rest of strings? The new strings we'd like are:

Want more from Mozilla? Check out other products that support a healthy internet. [ View more ]

@betsymi scope of this bug is to discuss adding tooltip to close icon. My understanding this will be a code change and needs to ride trains.

As for changing infobar text copy for Fx96 experiment, "Want more from Mozilla? Check out other products that support a healthy internet. [ View more ]" , we can do it remotely by passing hardcoded text in Nimbus experiment recipe with limitation of no styling to bold.

Comment 12

[Morgan Reschenberg [:morgan]]

(In reply to Meridel [:meridel] from comment #9)

Morgan, was there an accessibility consideration? Katie mentioned your comment about using "Dismiss."

Either should be fine from an a11y standpoint, as long as we're consistent with other browser UI.

Comment 13

[Meridel [:meridel]]

Great, thank you Flod and Morgan. Let's go with "Close" for the tooltip label for all infobar 'X' buttons.

Comment 14

[Meridel [:meridel]]

Punam, is there a bug for the Fx96 experiment that Betsy could use to share the new copy?

Comment 15

[Punam Dahiya [:pdahiya]]

Hi Meridel , for Fx 96 MfM experiment new copy should go in experiment design on mana https://mana.mozilla.org/wiki/display/FPS/%5BCross+Promotion%5D+More+from+Mozilla+-+Fx96

Comment 16

[Meridel [:meridel]]

Thanks, Punam. We have the latest copy on the Mana page.

Comment 18

[hanna A]

Attachment: Bug 1748464 - No tooltips displayed on infobar buttons, e.g., "Dismiss" from "More From Mozilla" or "Take Survey" for "Migration Survey" r?#omc-reviewers

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1aa6816d22e0
No tooltips displayed on infobar buttons, e.g., "Dismiss" from "More From Mozilla" or "Take Survey" for "Migration Survey" r=omc-reviewers,fluent-reviewers,flod,aminomancer

Comment 20

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/1aa6816d22e0

Comment 21

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 111.0a1, using the "Release" channel (Build ID: 20230209041032) on Windows 10x64 and Windows 11x64 and I can confirm the following:

• The "X" button from the "Migration Survey" Infobar has a "Close" tooltip when hovered.