1748473 - Spellcheck dialog breaks words with contractions at apostrophe (typographic single quote). Works with inline spellcheck.

Status: NEW

(Core :: Spelling checker, defect)

Description

[Doug Hockin]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:95.0) Gecko/20100101 Firefox/95.0

Steps to reproduce:

Forwarding a reply email that had "wasn't" in the quoted section of the email.

Actual results:

The spell checker complained about "wasn".

Expected results:

Should have recognized it as "wasn't".

Question: Does it make sense to spellcheck the quoted text?

Comment 1

[Doug Hockin]

Attachment: Screen Shot 2022-01-04 at 8.22.13 AM.png

Couldn't show the actual text it was complaining about about because the spellcheck dialog comes up on top of the text and can't be moved. Another bug (enhancement?) that I should report.

Comment 2

[Doug Hockin]

Upon second look, I see the text in question was not quoted, but rather in the forwarded part of the message.

Comment 3

[Wayne Mery (:wsmwk)]

Similar to Bug 1418629 - Spellcheck marks lost for words containing apostrophes

Comment 4

[Magnus Melin [:mkmelin]]

wasn't works fine for me

Comment 5

[Thomas D. (:thomas8)]

Attachment: Screenshot 2: Spell check dialog fails to recognize `wasn’t` with typographic quote (but OK for inline spell check)

(In reply to Magnus Melin [:mkmelin] from comment #4)

wasn't works fine for me

Yes, but works only with straight single quote mark '.

• The spell check dialog fails to recognize wasn’t with typographic single quote ’. Yet strangely, it's not underlined by inline spell check, which is correct albeit inconsistent.
• typing wassn’t and then using the suggested correction will replace typographic single quote with straight one, which isn't quite right either.
• quotations are correctly not spellchecked; reporter's case is forwarded text which isn't quoted, so checking that is probably OK.

Comment 6

[Thomas D. (:thomas8)]

Probably belongs into some spellcheck product/component?

Comment 8

[Thomas D. (:thomas8)]

For users who actually use the spellcheck dialogue and typographic single quotes, this will make for a pretty annoying experience, as all of the following will be presented as misspelled whilst they aren't:

Aren’t
I’ve
Should’ve
You’ve
Could’ve
They’ve
We’ve
Didn’t
Doesn’t
Can’t
Isn’t
Shouldn’t
Couldn’t
Wouldn’t
Hasn’t
Wasn’t
Weren’t
21st, 22nd, 23rd, 24th

Comment 9

[Magnus Melin [:mkmelin]]

Looks like this code should check typographical single quotes as well: https://searchfox.org/mozilla-central/rev/d7d2cc647772de15c4c5aa47f74d25d0e379e404/extensions/spellcheck/src/mozEnglishWordUtils.cpp#59,93

Comment 10

[dootydooter]

This still happens to me, when writing things on Notion.so. If I use a name such as "Iwasaka", I need to add it to the dictionary to avoid it from being underlined. However, when copy pasting in " Iwasaka’s ", the spellcheck underline is still there. If I type " Iwasaka's " somewhere, using ' instead of ’ it allows me to add it to the dictionary. However, Add to Dictionary fails when using words with ’ instead of ' .

Comment 11

[Sera Eris]

I specifically joined Bugzilla to report on this issue as well, as it's a constant problem for me as I write in a web-based editor ( Wavemaker Cards ).

Screenshot Link

Any custom names I add to my dictionary are fine, until I add a ( 's ) to them, at which point they're incorrect and there's nothing I can do to remedy that.

Plymothy is not a word by default, but as I'm in browser, let's add that to the dictionary.
Plymothy is now fine, no red line, but Plymothy's isn't.

Funny that I tested that in here- It appears to be fine in this text entry prompt.
So, in the interests of triage and bug hunting, the web app that I use that experiences this problem 100% of the time is: Wavemaker Cards
It is free, and does not require login or 3rd party services, so it should be testable.

I know this isn't an issue with the web app, as the dictionary is browser based, and I never had this issue when I was working in Chrome last year.

When the issue is present, selecting the entire word and adding it to dictionary does not work.
Right-clicking on any particular letter, including the apostrophe and 's', does not work either.

Firefox version: 134.0.2 (64-bit)
Up to date at time of comment.

Comment 12

[Sera Eris]

Attachment: Spellcheck Failing On Possessive Quotes ( 134.0.2 4-bit )