1748718 - [rust] Use the specified type for xpidl constants

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Nika Layzell [:nika] (ni? for response)]

This will reduce the need for unnecessary casts from i64 to the actual desired type in rust code which are implicit in c++ and JS.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1748718 - Part 1: Allow 64-bit integer constant types in xpidl, r=mccr8

The constants must fit within an int32_t or uint32_t as that is required by the
JS backend with xpt types holding a uint32_t and signed bit.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1748718 - Part 2: Use the specified type for rust xpidl constants, r=emilio

Previously all xpidl constants were specified as i64 which means they require
casts before being passed to any xpcom methods. The lack of typing was not an
issue in c++ due to implicit casts from enums to integer types, but using the
correct type is much more valuable in Rust.

Depends on D135164

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1748718 - Part 3: Remove now-unnecessary xpidl constant casts, r=emilio

Depends on D135165

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61f998fe727e
Part 1: Allow 64-bit integer constant types in xpidl, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/9d8cfa10fa95
Part 2: Use the specified type for rust xpidl constants, r=emilio
https://hg.mozilla.org/integration/autoland/rev/32873022d2ed
Part 3: Remove now-unnecessary xpidl constant casts, r=emilio

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/61f998fe727e
https://hg.mozilla.org/mozilla-central/rev/9d8cfa10fa95
https://hg.mozilla.org/mozilla-central/rev/32873022d2ed