Closed Bug 1748734 Opened 4 years ago Closed 2 years ago

[wpt-sync] Sync PR 32258 - Ensure backdrop filter cc::Layers are marked as drawing content

Categories

(Core :: Web Painting, task, P4)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32258 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32258
Details from upstream follow.

Philip Rogers <pdr@chromium.org> wrote:

Ensure backdrop filter cc::Layers are marked as drawing content

ContentLayerClientImpl::UpdateCcPictureLayer needs to set
cc::Layer::DrawsContent to true for content under a backdrop filter.
The previous code would do this based on the PendingLayer's effect node,
but this is incorrect if a single object has both a backdrop filter
effect node and a filter effect node. This approach failed to re-run
UpdateCcPictureLayer when HasBackdropEffect changed (see new WPT test
repaint-added-backdrop-filter.html).

This patch moves the source-of-truth for draws-content into PaintChunk,
and sets it based on whether any effect node could draw content.

Bug: 1273849
Change-Id: Ibb7c15361e83310881311122bf2cbec479a43d3a
Reviewed-on: https://chromium-review.googlesource.com/3367277
WPT-Export-Revision: d67783af903d4ea35b6fa0c3947e34a083daeb19

Component: web-platform-tests → Web Painting
Product: Testing → Core
Severity: -- → N/A
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.