Closed Bug 1748868 Opened 3 years ago Closed 3 years ago

New wpt failures in /html/canvas/element/manual/imagebitmap/createImageBitmap-colorSpaceConversion.html

Categories

(Core :: DOM: Core & HTML, defect)

defect

Tracking

()

RESOLVED FIXED
98 Branch
Tracking Status
firefox98 --- fixed

People

(Reporter: wpt-sync, Assigned: angus.sawyer)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [wpt])

Attachments

(1 file)

Syncing wpt PR 32256 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

/html/canvas/element/manual/imagebitmap/createImageBitmap-colorSpaceConversion.html
createImageBitmap from a bitmap HTMLImageElement, and drawImage on the created ImageBitmap with colorSpaceConversion: none: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]
createImageBitmap from a Blob, and drawImage on the created ImageBitmap with colorSpaceConversion: none: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1748725 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Assignee: nobody → angus.sawyer
Status: NEW → ASSIGNED
Attachment #9258926 - Attachment description: Bug 1748868 - support createImageBitmap colorSpaceConversion option, r=aosmond → Bug 1748868 - support createImageBitmap colorSpaceConversion option, r=aosmond,smaug
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b7411897419
support createImageBitmap colorSpaceConversion option, r=aosmond,emilio
Keywords: dev-doc-needed
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch

This has dev-doc-needed applied - what do you think needs doing?

Looking at this bug, it looks like you've added support to FF98 for the createImageBitmap() parameter named option, having the colorSpaceConversion property. Right?

Given this is already documented, I think the action is to update browser compatibility.

It is easy enough to indicate that FF98 is the first version of FF that supports this particular option. But for completeness it would be useful if you can tell me:

  • What other options do we support/not support?
  • For the options we support, were they all added in FF93 with the original addition of support for the options parameter?
  • Do we know Chrome and friends also implement this? Is there an easy way to test - e.g. a test I could run to "know"
Flags: needinfo?(angus.sawyer)

is already documented, I think the action is to update browser compatibility.>

Agreed, I have added entries to the release notes for this option.

It is easy enough to indicate that FF98 is the first version of FF that supports this particular option. But for completeness it would be useful if you can tell me:

  • What other options do we support/not support?
  • For the options we support, were they all added in FF93 with the original addition of support for the options parameter?

as of FF93 the options object was accepted and support for the options 'imageOrientation' and 'premultiplyAlpha' were added, unsupported options are ignored.

for FF98 the options 'colorSpaceConversion', 'resizeWidth' and 'resizeHeight' have been added
(see Bug 1733559 for resizeWidth and resizeHeight)

The only option unsupported after FF98 is resizeQuality which is ignored if provided.

  • Do we know Chrome and friends also implement this? Is there an easy way to test - e.g. a test I could run to "know"

Chrome and Edge support all options, WebKit is lagging. The wpt results at

https://wpt.fyi/results/html/canvas/element/manual/imagebitmap?label=experimental&label=master&aligned

are probably the best tests around, the test failures for FF98 for the resize tests are because resizeQuality isn't supported, incidentally most of the other imageBitmap test failures are because OffscreenCanvas isn't supported yet.

Hope that helps.

Flags: needinfo?(angus.sawyer)

Hi Angus,
That is extremely useful thanks - just what I needed.
FYI only the compatibility work is being done in https://github.com/mdn/browser-compat-data/pull/14876 (and other docs tidy up can be tracked in https://github.com/mdn/content/issues/12577#issuecomment-1031123701). I've marked dev-doc-complete because the broad work is done.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: