1748934 - Local Windows |./mach package| failures due missing maintenanceservice_installer.exe

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Ever since bug 1747347 landed, I've been unable to successfully run ./mach package locally due to the following error:

c:/mozilla-build/bin/mozmake.exe -C . -j32 -s -w package
mozmake: Entering directory 'C:/Users/Ryan/repos/mozilla/obj-x86_64-pc-mingw32'
mozmake[1]: Entering directory 'C:/Users/Ryan/repos/mozilla/obj-x86_64-pc-mingw32/browser/installer'
mozmake[2]: Entering directory 'C:/Users/Ryan/repos/mozilla/obj-x86_64-pc-mingw32/browser/installer'
mozmake[3]: Entering directory 'C:/Users/Ryan/repos/mozilla/obj-x86_64-pc-mingw32/browser/installer'
Error: $SRCDIR/browser/installer/package-manifest.in:398: Missing file(s): bin/maintenanceservice_installer.exe

Traceback (most recent call last):
  File "C:\Users\Ryan\repos\mozilla\toolkit\mozapps\installer\packager.py", line 298, in <module>
    main()
  File "C:\Users\Ryan\repos\mozilla\toolkit\mozapps\installer\packager.py", line 255, in main
    copier.add(mozpath.join(respath, "removed-files"), removals)
  File "c:\mozilla-build\python3\lib\contextlib.py", line 126, in __exit__
    next(self.gen)
  File "c:\users\ryan\repos\mozilla\python\mozbuild\mozpack\errors.py", line 132, in accumulate
    raise AccumulatedErrors()
mozpack.errors.AccumulatedErrors
mozmake[3]: *** [C:/Users/Ryan/repos/mozilla/toolkit/mozapps/installer/packager.mk;25: stage-package] Error 1
mozmake[3]: Leaving directory 'C:/Users/Ryan/repos/mozilla/obj-x86_64-pc-mingw32/browser/installer'
mozmake[2]: *** [C:/Users/Ryan/repos/mozilla/toolkit/mozapps/installer/packager.mk;111: make-package] Error 2
mozmake[2]: Leaving directory 'C:/Users/Ryan/repos/mozilla/obj-x86_64-pc-mingw32/browser/installer'
mozmake[1]: *** [C:/Users/Ryan/repos/mozilla/config/rules.mk;352: default] Error 2
mozmake[1]: Leaving directory 'C:/Users/Ryan/repos/mozilla/obj-x86_64-pc-mingw32/browser/installer'
mozmake: *** [C:/Users/Ryan/repos/mozilla/browser/build.mk;6: package] Error 2
mozmake: Leaving directory 'C:/Users/Ryan/repos/mozilla/obj-x86_64-pc-mingw32'

I've reproduced this with a minimal mozconfig (only --enable-application=browser set) and have tried clobbering. I've also confirmed that backing out the 3 changesets from that bug allows it to run successfully again. I haven't attempted to bisect which of the 3 changesets was responsible, but can do so if it'll help.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Output from mach configure

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: config.log

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1748934 - Add missing local-toolchain attribute to nsis.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d0e9e83fac6
Add missing local-toolchain attribute to nsis. r=firefox-build-system-reviewers,nalexander

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/611ec542121f
Bustage fix. r=glandium on a CLOSED TREE

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8d0e9e83fac6
https://hg.mozilla.org/mozilla-central/rev/611ec542121f