1748940 - nsImapBodyShell spring cleaning

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, task)

Description

[Ben Campbell]

Just following up a few rough edges I noticed during Bug 847356, in nsIMapBodyShell and adjacent code.

• Some classes have pointer members which would be safer/clearer as embedded objects (eg there are a couple of classes with nsTArray<>* members).
• nsIMapBodyShellCache does extra work it doesn't need in dtor and Clear().
• some general minor tidying and cruft-removal

Comment 1

[Ben Campbell]

Attachment: Bug 1748940 - Assorted minor nsImapBodyShellCache tidying. r=mkmelin

• Add central definition for max size (kMaxEntries).
• Ensure a free slot before adding new entry (rather than going oversize then trimming back).
• Embed nsTArray<> rather than separate heap alloc.
• Reduce work done during dtor and clear.
• Ditch static Create() function and make ctor public.
• Remove returncodes for fns which don't really need them.

Depends on D135191

Comment 2

[Ben Campbell]

Attachment: Bug 1748940 - Use nsTArray<> instead of nsTArray<>* for nsIMAPBodypartMultipart subpart list. r=mkmelin

Depends on D135298

Comment 3

[Ben Campbell]

I think that wraps up this one. There's some frustratingly opaque char* memory handling (mainly with partNum strings), but that's better covered in Bug 1727467.

Comment 4

[Ben Campbell]

Holding off until after beta.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8a413ffc8acb
Assorted minor nsImapBodyShellCache tidying. r=mkmelin
https://hg.mozilla.org/comm-central/rev/5a54066d8cfd
Use nsTArray<> instead of nsTArray<>* for nsIMAPBodypartMultipart subpart list. r=mkmelin