1748981 - hal::LockScreenOrientation in content process never returns rejected promise even if platform's implementation returns rejected promise

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[Makoto Kato [:m_kato]]

Here. IPC's promise returns resolved promise when IPC connection is successful. So even if platform implementations such as android returns rejected promise, it is converted to resolved promise by SandboxHal.cpp.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1748981 - hal::LockScreenOrientation in content process never returns rejected promise even if platform's implementation returns rejected promise. r=calu

IPC's promise returns resolved promise when IPC connection is successful. So
even if platform implementations such as android returns rejected promise, it
is converted to resolved promise by SandboxHal.cpp unfortunately.

So we should check return value when RecvLockScreenOrientation returns false.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86c9c78b8664
hal::LockScreenOrientation in content process never returns rejected promise even if platform's implementation returns rejected promise. r=calu

Comment 3

[Marian-Vasile Laza]

Backed out changeset 86c9c78b8664 (Bug 1748981) for causing geckoview test failures.
Backout link
Push with failures
Failure Log

Comment 4

[Makoto Kato [:m_kato]]

ah, GV-junit has a bug then we should use delegateDuringNextWait when returning value. I will fix it

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1748981 - Use delegateDuringNextWait when returning GeckoResult. r=calu

When looking test failure, I found that onOrientationLock always returned
null in geckoview-junit since default method is called.

We should use use delegateDuringNextWait instead of waitUntilCalled.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4df658fcf42d
hal::LockScreenOrientation in content process never returns rejected promise even if platform's implementation returns rejected promise. r=calu
https://hg.mozilla.org/integration/autoland/rev/5e151bd74f2a
Use delegateDuringNextWait when returning GeckoResult. r=calu

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/4df658fcf42d
https://hg.mozilla.org/mozilla-central/rev/5e151bd74f2a

Comment 8

[Marian-Vasile Laza]

Backed out 2 changesets (Bug 1748981) for causing high freq geckoview test failures.
Backout link
Push with failures
Failure Log

Comment 9

[Makoto Kato [:m_kato]]

(In reply to Marian-Vasile Laza from comment #8)

Backed out 2 changesets (Bug 1748981) for causing high freq geckoview test failures.
Backout link
Push with failures
Failure Log

This is another bug. After landing bug 1747039, I will land this.

Comment 10

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=KkekHXehTuGgpyuYk3cK4Q.0&revision=e828dbc282b4811d4b530c7a6f0d28558ead2d06 is no timeout failure

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/882e17b0cc21
hal::LockScreenOrientation in content process never returns rejected promise even if platform's implementation returns rejected promise. r=calu
https://hg.mozilla.org/integration/autoland/rev/6a2fd520e84f
Use delegateDuringNextWait when returning GeckoResult. r=calu

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/882e17b0cc21
https://hg.mozilla.org/mozilla-central/rev/6a2fd520e84f