1749013 - Intermittent devtools/client/jsonview/test/browser_jsonview_save_json.js | JSON contents should have been saved. - Got "", expected "3"

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mlaza [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=363369569&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VMoLGDWXQ_uHAvECpLWSUQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VMoLGDWXQ_uHAvECpLWSUQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2022-01-07T13:00:06.285Z] 13:00:06     INFO - TEST-PASS | devtools/client/jsonview/test/browser_jsonview_save_json.js | The downloaded file should exist. - 
[task 2022-01-07T13:00:06.286Z] 13:00:06     INFO - Buffered messages finished
[task 2022-01-07T13:00:06.287Z] 13:00:06     INFO - TEST-UNEXPECTED-FAIL | devtools/client/jsonview/test/browser_jsonview_save_json.js | JSON contents should have been saved. - Got "", expected "3"
[task 2022-01-07T13:00:06.287Z] 13:00:06     INFO - Stack trace:
[task 2022-01-07T13:00:06.288Z] 13:00:06     INFO - chrome://mochikit/content/browser-test.js:test_is:1403
[task 2022-01-07T13:00:06.289Z] 13:00:06     INFO - chrome://mochitests/content/browser/devtools/client/jsonview/test/browser_jsonview_save_json.js:null:154
[task 2022-01-07T13:00:06.290Z] 13:00:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1130
[task 2022-01-07T13:00:06.290Z] 13:00:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1170
[task 2022-01-07T13:00:06.291Z] 13:00:06     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:972
[task 2022-01-07T13:00:06.292Z] 13:00:06     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041
[task 2022-01-07T13:00:06.292Z] 13:00:06     INFO - Leaving test bound 
[task 2022-01-07T13:00:06.293Z] 13:00:06     INFO - TEST-PASS | devtools/client/jsonview/test/browser_jsonview_save_json.js | JSON should have been downloaded successfully - 

Comment 1

[Atila Butkovits]

Started failing on tier1 jobs: https://treeherder.mozilla.org/logviewer?job_id=363443708&repo=mozilla-central&lineNumber=23533

Comment 2

[Oriol Brufau [:Oriol]]

Seems a race condition exposed by bug 1748688, due to merging getFileContents into awaitFileSave.

Comment 3

[Oriol Brufau [:Oriol]]

Attachment: Bug 1749013 - Fix browser_jsonview_save_json.js checking disk data too early. r?Honza

Comment 4

[Intermittent Failures Robot]

3 failures in 2801 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64-qr: 2
  • opt: 1
  • debug: 1
• linux1804-64-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1749013&startday=2022-01-03&endday=2022-01-09&tree=all

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1391c4dcf721
Fix browser_jsonview_save_json.js checking disk data too early. r=Honza

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1391c4dcf721

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1ea14dc6c23b