1749134 - Uncaught TypeError: aEvent.currentTarget.menupopup is null when left-clicking on the new tab button with containers disabled

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P3)

Description

[kernp25]

Attachment: firefox_DXpaUxkmcG.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:95.0) Gecko/20100101 Firefox/95.0

Steps to reproduce:

1. Set the pref privacy.userContext.enabled to false
2. Left-click on the new tab button

Actual results:

Uncaught TypeError: aEvent.currentTarget.menupopup is null will show in the browser console.

Comment 1

[kernp25]

Can you confirm this bug and set it to NEW (and provide a regression window?)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::New Tab Page' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Alice0775 White]

I cannot reproduce the issue.

Comment 4

[kernp25]

Attachment: firefox_5I7gAp6UKt.mp4

Can you reproduce?

Comment 5

[Alex Cornestean]

Hello @kernp25,

I managed to reproduce the issue on the latest Nightly (97.0a1/20220109215539), Beta (96.0/20220106144528) and Release (95.0.2/20211218203254) under Windows 10 x64.

I did however have to flip the privacy.userContext.enabled pref to true (from it’s default state of false) and then flip it back to false in order to reproduce the issue. After this, left clicking on the new tab button produced the mentioned error.

Comment 6

[Alex Cornestean]

Attachment: 2022-01-10_09h45_58.png

Comment 7

[Dale Harvey (:daleharvey)]

This looks to be related to menus being enabled / disabled

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

I think the bug is related to this code,
https://searchfox.org/mozilla-central/rev/080e18fa4748456003164f58b0d925b8c3826a67/browser/base/content/tabbrowser-tabs.js#1051-1052,1082-1083

Comment 9

[:Gijs (he/him)]

Attachment: Bug 1749134 - fix error message when toggling containers caused by not removing from gClickAndHoldListenersOnElement, r?jaws

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1613250

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91c1ba9787b4
fix error message when toggling containers caused by not removing from gClickAndHoldListenersOnElement, r=jaws

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/91c1ba9787b4

Comment 13

[Ardelean Oana, Desktop QA [:oardelean]]

I managed to reproduce this issue on Firefox 97(20220202182137) using the STR from comment 5 on macOS Big Sur 11. This bug is fixed on Firefox 98.0b5(20220215194438) and Nightly 99.0a1(20220215210051) on macOS Big Sur 11, Linux x86_64(Ubuntu 20.04) and Win10.