174921 - casting in nsInMemoryDataSource is fishy

Status: RESOLVED INCOMPLETE

(Core Graveyard :: RDF, defect)

Description

[Boris Zbarsky [:bzbarsky]]

InMemoryArcsEnumeratorImpl::ArcEnumerator puts a bunch of nsIRDFNode objects
into an nsISupportsArray.  After that, many callsites get them out and cast to
nsIRDFResource....

If the objects are in fact nsIRDFResource objects, it may make sense to cast
them on insertion to make it clear what's going on (and to allow the use of an
nsCOMArray instead of nsISupportsArray).

Of course there's the question of whether they are always nsIRDFResources...

Comment 1

[Chase Tingley]

The property for an RDF arc (which is what's being put in the array here) is
always a resource, so there shouldn't be any danger here.  That said, the
suggestion is valid.

Comment 2

[Axel Hecht]

waterson left the building