1749224 - JetStream 2 UniPoker Error

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect)

Description

[Kim Visscher]

Attachment: JavaScript Console Stracktrace Export

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:97.0) Gecko/20100101 Firefox/97.0

Steps to reproduce:

I tried to run the JetStream2 benchmark, with 97.0a1 nightly (2022-01-08) (64-bit).

Actual results:

It gave an JavaScript exception on UniPoker, stating that there is a mismatch between an expected value and an actual one.

See the console-export.txt attached to this bug report for the actual stacktrace/message.

Expected results:

It should have run the JetStream2 benchmark just fine.
(Though I'm not quite sure if this is an JetStream2 bug or an Firefox bug.)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::WebRTC' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Nicolas B. Pierron [:nbp]]

I was not able to reproduce this issue on Linux with versions 97.0a1 nor 98.0a1.

Can you always reproduce this issue?
Would you be able to bisect the version of Firefox which caused this regression?

Comment 3

[Kim Visscher]

(In reply to Nicolas B. Pierron [:nbp] from comment #2)

I was not able to reproduce this issue on Linux with versions 97.0a1 nor 98.0a1.

Can you always reproduce this issue?

Yes, I am able to consistently reproduce this issue (i.e. always).
I'm now on 98.0a1 build: 20220111093827 and I'm still getting this.

Would you be able to bisect the version of Firefox which caused this regression?

No because I've only ever run JetStream 2 on 97.0a1, it was my first run ever.

---

I checked with Edge Version 97.0.1072.55 (Official build) (64-bit) and it runs UniPoker fine.

I've attached an about_support.txt generated from the about:support page, if there's anything else you would like, please let me know.

I did install a plug-in that uses regular expressions, but I've disabled it and the result for running UniPoker is the same regardless its enabled status.

Comment 4

[Kim Visscher]

Attachment: about:support Export

Comment 5

[Kim Visscher]

Attachment: reproduction.mp4

Comment 6

[Kim Visscher]

Okay so I think I might have found the culprit; MetaMask, when I run JetStream 2 with MetaMask enabled it fails, when i run JetStream 2 with MetaMask disabled it succeeds.
I've attached a screen recording that shows JetStream 2 succeeding with MetaMask disabled and JetStream 2 failing with MetaMask enabled.

How can plugins like MetaMask mess with Firefox's regular expressions that bad?

Comment 7

[Nicolas B. Pierron [:nbp]]

(In reply to Kim Visscher from comment #6)

Okay so I think I might have found the culprit; MetaMask, when I run JetStream 2 with MetaMask enabled it fails, when i run JetStream 2 with MetaMask disabled it succeeds.
I've attached a screen recording that shows JetStream 2 succeeding with MetaMask disabled and JetStream 2 failing with MetaMask enabled.

Thanks for figuring this out. It would have been really hard for us to find this.

How can plugins like MetaMask mess with Firefox's regular expressions that bad?

It is possible that MetaMask load extra scripts in the page content using the activeTab permission which are messing up with the benchmark execution, such as replacing a function by another.

Comment 8

[Nicolas B. Pierron [:nbp]]

From the current info, we do not know if this is a Firefox issue or a MetaMask issue.
Is there a MetaMask issue that we can follow?

Comment 9

[Kim Visscher]

I've filled a issue with them just now.

Comment 10

[Nicolas B. Pierron [:nbp]]

While waiting for feedback from MetaMask, I will flag this bug as Incomplete.
As soon as we have more information pointing forward an unexpected behavior of Firefox, we should re-open and investigate this issue.