Closed Bug 1749242 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 32302 - Fix letterSpacing and wordSpacing values

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
98 Branch
Tracking Status
firefox98 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32302 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32302
Details from upstream follow.

Yi Xu <yiyix@chromium.org> wrote:

Fix letterSpacing and wordSpacing values

According to the WhatWG spec letterSpacing and wordSpacing returns
the serialized CSS \<length> value. The following should hold:
ctx.letterSpacing = '5PX'
ctx.letterSpacing // returns 5px. (lowercase)

Updated code to fix this issue.

Bug: 1263632

Change-Id: Ic894e322f6ad5e27f3d299114674b77e319b9656

Reviewed-on: https://chromium-review.googlesource.com/3376722
WPT-Export-Revision: 26b4179b6bb13636c1b98524187feafad9a9d570

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
FAIL: 3

Chrome

OK : 3
FAIL: 3

Safari

OK : 3
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/element/drawing-text-to-the-canvas/2d.text.drawing.style.spacing.html
Testing letter spacing and word spacing: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.spacing.html
Testing letter spacing and word spacing: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.spacing.worker.html
Testing letter spacing and word spacing: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66d086bf9065 [wpt PR 32302] - Fix letterSpacing and wordSpacing values, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.