1749291 - Box around extension popups and Pocket popup

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Viktor Jägersküpper]

Attachment: Box around uBlock Origin popup

With the current Nighty I almost always get a box around extension popups (e.g. uBlock Origin) and around the Pocket popup, but not around e.g. the hamburger menu and the bookmarks menu popup. This is a recent regression.

Result given by mozregression:
Last good revision: 8d62b2808079d574d68533b63c967a08f78bc0db
First bad revision: 7e3cdb88790d2ddf7a3797a4374cf38f106b86d0
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8d62b2808079d574d68533b63c967a08f78bc0db&tochange=7e3cdb88790d2ddf7a3797a4374cf38f106b86d0

This is part of bug 1742358.

OS: Arch Linux
Seen with Gnome X11/XWayland/Wayland and KDE Wayland

Comment 1

[Viktor Jägersküpper]

I don't see this with gfx.webrender.software enabled nor with gfx.webrender.compositor.force-enabled enabled on Gnome and KDE.

Comment 2

[Darkspirit]

IIUC, bug 1674473 fixed clear color for SW WR back then.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

huh, I tested the hamburger menu but apparently not the webext popup, fun.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1749291 - Don't change clear color of popups. r=stransky

They don't have a parent but they aren't root windows and won't receive
the non-blank paint notification.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d2a65f1e836
Don't change clear color of popups. r=stransky

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8d2a65f1e836

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9258368 [details]
Bug 1749291 - Don't change clear color of popups. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial one-liner
• String changes made/needed: none

Comment 9

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build 98.0a1 (20220110213134) on Ubuntu 20.04.

Verified fixed on 98.0a1 (20220112095252), Ubuntu 20.04. The box no longer appears around Pocket or extension popups.

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9258368 [details]
Bug 1749291 - Don't change clear color of popups. r=stransky

Approved for 97.0b3. Thanks.

Comment 11

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/77315382ed55

Comment 12

[Giorgia Nichita, Release Desktop QA]

Verified fixed on 97.0b3 using a treeherder build (Build ID: 20220112193650) on Ubuntu 20.04.