[dogfood] file | send page gets obscure error message when trying to send

VERIFIED FIXED in M11

Status

MailNews Core
Composition
P3
normal
VERIFIED FIXED
19 years ago
10 years ago

People

(Reporter: chris hofmann, Assigned: Jean-Francois Ducarroz)

Tracking

Trunk
x86
Windows 95

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [PDT+], URL)

(Reporter)

Description

19 years ago
go to test URL
file | send page
mail compose window starts
type in a to: address
hit send
get a funny error dialog
   "[StringID-21447418113]"

want to send web pages to eat yummy dog food.
chris h.
(Reporter)

Updated

19 years ago
Summary: dogfood file | send page gets obscure error message when trying to send → [dogfood] file | send page gets obscure error message when trying to send
(Assignee)

Comment 1

19 years ago
What appends here is that the file name generated by the function
GenerateFileNameFromURI() in mailnews/compose/src/nsMsgCompUtil.cpp is invalid.
In this case it returns (without the double quotes)
"navbar.tmpl?cp=mynet.254&service=net.254&id=item_0&h=1587966223".

I have a fix that strip everything from the first '?' to the end. Now I get only
"navbar.tmpl" and it works much better.

Rich, can you review the following patch (tested on Mac & Windows):

Index: nsMsgCompUtils.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/compose/src/nsMsgCompUtils.cpp,v
retrieving revision 1.41
diff -r1.41 nsMsgCompUtils.cpp
1926c1926,1929
<       if ((cp1 = PL_strchr(cp, '/'))) *cp1 = 0;
---
>       if ((cp1 = PL_strchr(cp, '/'))) *cp1 = 0;
>         // strip '?'
>       if ((cp1 = PL_strchr(cp, '?'))) *cp1 = 0;
>

Comment 2

19 years ago
Looks good to me.

- rhp

Updated

19 years ago
Whiteboard: [PDT+]

Comment 3

19 years ago
Putting on [PDT+] radar.
(Assignee)

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

19 years ago
Fixed and checked in

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 5

19 years ago
Linux Redhat 6.0 (1999-11-08-08 M11)
Win32 on Win_nt 4.0 and Win 95 (1999-11-08-0 M11)
Linux Redhat 6.0 (1999-11-08-08 M11)
I did a send on each of these platforms, the problem has been fixed.
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.