Closed Bug 1749302 Opened 3 years ago Closed 3 years ago

Assertion failure: [GFX1]: void mozilla::gl::GLContext::fHint(GLenum, GLenum): Generated unexpected GL_INVALID_ENUM error, at /gfx/2d/Logging.h:751

Categories

(Core :: Graphics: CanvasWebGL, defect, P2)

Product:
Core
Component:
Graphics: CanvasWebGL
Platform:
x86_64
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox98 --- verified

People

(Reporter: jkratzer, Assigned: jgilbert)

References

(Blocks 1 open bug)

Details

(Keywords: testcase, Whiteboard: [bugmon:bisected,confirmed])

Attachments

(2 files)

Testcase
295 bytes, text/plain
Details
Bug 1749302 - Validate `mode` for webgl.hint().
48 bytes, text/x-phabricator-request
Details | Review

Testcase found while fuzzing mozilla-central rev b81970e39db4 (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build b81970e39db4 --debug --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html

Assertion failure: [GFX1]: void mozilla::gl::GLContext::fHint(GLenum, GLenum): Generated unexpected GL_INVALID_ENUM error, at /gfx/2d/Logging.h:751

    ==551510==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f6e1715b10f bp 0x7ffc5d730dc0 sp 0x7ffc5d730db0 T551510)
    ==551510==The signal is caused by a WRITE memory access.
    ==551510==Hint: address points to the zero page.
        #0 0x7f6e1715b10f in mozilla::gfx::Log<1, mozilla::gfx::CriticalLogger>::WriteLog(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /gfx/2d/Logging.h:752:9
        #1 0x7f6e1715b01e in mozilla::gfx::Log<1, mozilla::gfx::CriticalLogger>::Flush() /gfx/2d/Logging.h:277:7
        #2 0x7f6e1719312e in mozilla::gfx::Log<1, mozilla::gfx::CriticalLogger>::~Log() /gfx/2d/Logging.h:270:12
        #3 0x7f6e1723d8c2 in mozilla::gl::GLContext::AfterGLCall_Debug(char const*) const /gfx/gl/GLContext.cpp:2603:7
        #4 0x7f6e1911264d in AfterGLCall /gfx/gl/GLContext.h:684:7
        #5 0x7f6e1911264d in fHint /gfx/gl/GLContext.h:1408:5
        #6 0x7f6e1911264d in mozilla::WebGLContext::Hint(unsigned int, unsigned int) /dom/canvas/WebGLContextGL.cpp:744:7
        #7 0x7f6e1903f8cc in Hint /dom/canvas/HostWebGLContext.h:401:59
        #8 0x7f6e1903f8cc in void mozilla::ClientWebGLContext::Run<void (mozilla::HostWebGLContext::*)(unsigned int, unsigned int) const, &(mozilla::HostWebGLContext::Hint(unsigned int, unsigned int) const), unsigned int&, unsigned int&>(unsigned int&, unsigned int&) const /dom/canvas/ClientWebGLContext.cpp:344:12
        #9 0x7f6e1903f7df in mozilla::ClientWebGLContext::Hint(unsigned int, unsigned int) /dom/canvas/ClientWebGLContext.cpp:2817:3
        #10 0x7f6e18844a7c in mozilla::dom::WebGL2RenderingContext_Binding::hint(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/WebGL2RenderingContextBinding.cpp:14252:24
        #11 0x7f6e18f47e88 in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /dom/bindings/BindingUtils.cpp:3306:13
        #12 0x7f6e1c9afcaf in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) /js/src/vm/Interpreter.cpp:425:13
        #13 0x7f6e1c9af3ad in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:512:12
        #14 0x7f6e1c9b0e8e in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /js/src/vm/Interpreter.cpp:572:10
        #15 0x7f6e1c9a6696 in CallFromStack /js/src/vm/Interpreter.cpp:576:10
        #16 0x7f6e1c9a6696 in Interpret(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:3309:16
        #17 0x7f6e1c99d5b3 in js::RunScript(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:394:13
        #18 0x7f6e1c9af2a8 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:544:13
        #19 0x7f6e1c9b0e8e in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /js/src/vm/Interpreter.cpp:572:10
        #20 0x7f6e1c9b1091 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:589:8
        #21 0x7f6e1cb70c71 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /js/src/vm/CallAndConstruct.cpp:117:10
        #22 0x7f6e18c5d727 in mozilla::dom::EventListener::HandleEvent(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/EventListenerBinding.cpp:62:8
        #23 0x7f6e19410e06 in void mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget*>(mozilla::dom::EventTarget* const&, mozilla::dom::Event&, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/EventListenerBinding.h:65:12
        #24 0x7f6e19410b8a in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) /dom/events/EventListenerManager.cpp:1303:43
        #25 0x7f6e19411889 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) /dom/events/EventListenerManager.cpp:1500:17
        #26 0x7f6e194068b4 in HandleEvent /dom/events/EventListenerManager.h:395:5
        #27 0x7f6e194068b4 in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:348:17
        #28 0x7f6e19405dd7 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:550:16
        #29 0x7f6e19408638 in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) /dom/events/EventDispatcher.cpp:1085:11
        #30 0x7f6e1abbb1d3 in nsDocumentViewer::LoadComplete(nsresult) /layout/base/nsDocumentViewer.cpp:1086:7
        #31 0x7f6e1c1b7ac4 in nsDocShell::EndPageLoad(nsIWebProgress*, nsIChannel*, nsresult) /docshell/base/nsDocShell.cpp:6278:20
        #32 0x7f6e1c1b75b3 in nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) /docshell/base/nsDocShell.cpp:5667:7
        #33 0x7f6e1c1b844f in non-virtual thunk to nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) /docshell/base/nsDocShell.cpp
        #34 0x7f6e1701f5bc in nsDocLoader::DoFireOnStateChange(nsIWebProgress*, nsIRequest*, int&, nsresult) /uriloader/base/nsDocLoader.cpp:1377:3
        #35 0x7f6e1701eb4a in nsDocLoader::doStopDocumentLoad(nsIRequest*, nsresult) /uriloader/base/nsDocLoader.cpp:975:14
        #36 0x7f6e1701ced0 in nsDocLoader::DocLoaderIsEmpty(bool, mozilla::Maybe<nsresult> const&) /uriloader/base/nsDocLoader.cpp:794:9
        #37 0x7f6e1701e08d in nsDocLoader::OnStopRequest(nsIRequest*, nsresult) /uriloader/base/nsDocLoader.cpp:677:5
        #38 0x7f6e1c1d8f0d in nsDocShell::OnStopRequest(nsIRequest*, nsresult) /docshell/base/nsDocShell.cpp:13540:23
        #39 0x7f6e15d9ac2a in mozilla::net::nsLoadGroup::NotifyRemovalObservers(nsIRequest*, nsresult) /netwerk/base/nsLoadGroup.cpp:614:22
        #40 0x7f6e15d9c213 in mozilla::net::nsLoadGroup::RemoveRequest(nsIRequest*, nsISupports*, nsresult) /netwerk/base/nsLoadGroup.cpp:518:10
        #41 0x7f6e179eb3c5 in mozilla::dom::Document::DoUnblockOnload() /dom/base/Document.cpp:11554:18
        #42 0x7f6e179b5f23 in mozilla::dom::Document::UnblockOnload(bool) /dom/base/Document.cpp:11484:9
        #43 0x7f6e179d1deb in mozilla::dom::Document::DispatchContentLoadedEvents() /dom/base/Document.cpp:7999:3
        #44 0x7f6e17a8307b in applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1147:12
        #45 0x7f6e17a8307b in apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1153:12
        #46 0x7f6e17a8307b in mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1200:13
        #47 0x7f6e15ba0b92 in mozilla::SchedulerGroup::Runnable::Run() /xpcom/threads/SchedulerGroup.cpp:144:20
        #48 0x7f6e15bd0ece in mozilla::RunnableTask::Run() /xpcom/threads/TaskController.cpp:468:16
        #49 0x7f6e15baad26 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:771:26
        #50 0x7f6e15ba99e8 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:607:15
        #51 0x7f6e15ba9c63 in mozilla::TaskController::ProcessPendingMTTask(bool) /xpcom/threads/TaskController.cpp:391:36
        #52 0x7f6e15bd3f06 in operator() /xpcom/threads/TaskController.cpp:124:37
        #53 0x7f6e15bd3f06 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:531:5
        #54 0x7f6e15bbf623 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1195:16
        #55 0x7f6e15bc670a in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:467:10
        #56 0x7f6e16669c86 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:85:21
        #57 0x7f6e165897c7 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:331:10
        #58 0x7f6e165896d2 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #59 0x7f6e165896d2 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #60 0x7f6e1a808158 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:137:27
        #61 0x7f6e1c833a83 in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:864:20
        #62 0x7f6e1666ab7a in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:235:9
        #63 0x7f6e165897c7 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:331:10
        #64 0x7f6e165896d2 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #65 0x7f6e165896d2 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #66 0x7f6e1c8330bb in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:701:34
        #67 0x55acd1379029 in content_process_main /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #68 0x55acd1379029 in main /browser/app/nsBrowserApp.cpp:327:18
        #69 0x7f6e2bdce0b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
        #70 0x55acd13547bc in _start (/home/jkratzer/builds/mc-debug/firefox-bin+0x157bc)
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /gfx/2d/Logging.h:752:9 in mozilla::gfx::Log<1, mozilla::gfx::CriticalLogger>::WriteLog(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
    ==551510==ABORTING
Attached file Testcase —

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220110093702-b81970e39db4.
Failed to bisect testcase (Testcase reproduces on start build!):

Start: 7643eaee62a3f09e252eed29ff7d649a708757e9 (20210111093448)
End: b81970e39db444fa9a70eaf2e656f3e48c18a7c1 (20220110093702)
BuildFlags: BuildFlags(asan=False, tsan=False, debug=True, fuzzing=True, coverage=False, valgrind=False, no_opt=False, fuzzilli=False)

Whiteboard: [bugmon:confirm] → [bugmon:bisected,confirmed]

The severity field is not set for this bug.
:jgilbert, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jgilbert)

Interesting, looks like the driver doesn't like invalid hint values for hint keys. I assumed that it wouldn't care, being that they're, y'know, hints. :)

Severity: -- → S4
Flags: needinfo?(jgilbert)
Priority: -- → P2

This obviously needs a CTS test added as well.

Assignee: nobody → jgilbert
Status: NEW → ASSIGNED
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d5ccd4acfd3 Validate `mode` for webgl.hint(). r=gfx-reviewers,lsalzman

https://hg.mozilla.org/mozilla-central/rev/8d5ccd4acfd3

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch

Bugmon Analysis
Verified bug as fixed on rev mozilla-central 20220131165143-bb528a123b65.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Status: RESOLVED → VERIFIED
status-firefox98: fixed → verified
Keywords: bugmon

:jgilbert, since this bug contains a bisection range, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Flags: needinfo?(jgilbert)

Sorry, wrong needinfo because of a bug in the bot.

Flags: needinfo?(jgilbert)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: