1749331 - can failed browsertime tasks upload fewer screenshots?

Status: RESOLVED FIXED

(Testing :: Raptor, task, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://treeherder.mozilla.org/logviewer?job_id=363593448&repo=autoland&lineNumber=1078 is a failed browsertime task which uploaded to 1034 artifacts to Taskcluster: 3 logs, 2 videos, 1 config file, 1 performance data summary and 1027 screenshots (continuation token used).

The checked screenshot has 712KB size. The tasks shouldn't upload these by default if the task failed.

Comment 1

[Greg Mierzwinski [:sparky]]

We'll put this into our pain points work. The issue here is that the results all get stored in the blobber_upload_dir when they should be placed into a temp folder first.

Comment 2

[Greg Mierzwinski [:sparky]]

We could remove PNGs/JPEGs in this area before finishing the test: https://searchfox.org/mozilla-central/source/testing/raptor/raptor/perftest.py#470,481

Comment 3

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1749331 - Prevent uploading more than 5 PNG/JPEG artifacts. r?#perftest

This patch adds some logic to clean up the artifact folder from the hundreds of PNG/JPEGs generated on task failures. It sorts the files and attempts to only keep the 5 newest images so that we can still use them for debugging issues.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8ccda3bfa11
Prevent uploading more than 5 PNG/JPEG artifacts. r=perftest-reviewers,kshampur

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c8ccda3bfa11