1749347 - [wpt-sync] Sync PR 32310 - Fix canvas crash when letterspacing/wordspacing are set to invalid value

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32310 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32310
Details from upstream follow.

Yi Xu <[e-mail]> wrote:

Fix canvas crash when letterspacing/wordspacing are set to invalid value

Canvas now crashes with the following code:
ctx.letterSpacing = 2sec

In this cl, I verify if letterSpacing is set to a CSS length value before
assigning it.

Bug: 1285756

Change-Id: Ie678383337677feed6dfacd6be99d0f6f34fbeb9

Reviewed-on: https://chromium-review.googlesource.com/3376723
WPT-Export-Revision: bc4f5402d8a6683ad12213f42b4ef9fea1c36f95

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b846c6c3031a3038b9ab4f1478418f7aec6d6e1

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
FAIL: 3

Chrome

OK : 3
FAIL: 3

Safari

OK : 3
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/element/drawing-text-to-the-canvas/2d.text.drawing.style.invalid.spacing.html
Testing letter spacing and word spacing with invalid units: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.invalid.spacing.html
Testing letter spacing and word spacing with invalid units: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.invalid.spacing.worker.html
Testing letter spacing and word spacing with invalid units: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/97a7369972fd
https://hg.mozilla.org/mozilla-central/rev/9e99f35938b2